Skip to content

Create lab fails but says DONE #86

Description

@pejg12

I can't find the code for "dbwebb create lab4" so I can't fix this myself.

The issue is that when the lab fails to create, it still outputs "DONE You can find the lab and all files here". Something like this:

$ dbwebb create lab4
Creating htmlphp lab4 in '$HOMEPATH/dbwebb-kurser/htmlphp/me/kmom05/lab4'.
Downloading and extracting lab bundle
tar: This does not look like a tar archive
tar: Exiting with failure status due to previous errors
DONE You can find the lab and all files here:
'$HOMEPATH/dbwebb-kurser/htmlphp/me/kmom05/lab4'
total 0

To fix this issue, you could check the $? value, and if it's not 0 then the dbwebb code should exit with a non-zero code as well. Like I did in this commit: 1ec300a

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions