Skip to content

Possible rewrite to allow custom send time #49

Description

@NiklasAurora

irc2phpbb/marvin.py

Lines 295 to 300 in be7ec47

else:
for action in GENERAL_ACTIONS:
msg = action(set(row), row, raw)
if msg:
sendPrivMsg(msg, words[2])
break

As of now, this implementation lets Marvin respond to phrases without being mentioned. However, his response will be sent immediately after, as if he was mentioned.

Solutions tried:

  • Adding a file to /incoming but as Marvin reads the message, he outputs what's in /incoming, instantly writing the message anyway.

  • Sleep() queues any further actions from Marvin, which results in tons of spam from him depending on activity on the forums and questions asked.

  • Multithreaded/async-await: move the write to chat to another thread, then sleep. However, this would mean most of Marvin would have to be rewritten or I am completely lost in how to implement it. (most likely the latter).

Possible solutions would be a new folder for queued messages, unsure of rest of implementation but would have to be separate from /incoming

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions