Repository navigation
Conversation
The open tabs menu can now add a tab to a new group, to an existing open or closed group, and remove it from its group, matching the tab strip. The group policy, actions and chicklet colors are extracted into TabGroupMenu.sys.mjs and tab-group-colors.css so the tab strip, the all tabs panel and Firefox View share one implementation. Co-authored-by: Cursor <cursoragent@cursor.com>
No Taskcluster jobs started for this pull requestThe |
Contributor
|
(Automated Close) Please do not file pull requests here, see https://firefox-source-docs.mozilla.org/contributing/how_to_submit_a_patch.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=2076116
The Firefox View open tabs menu now offers the same tab group actions as the tab strip: add a tab to a new group, add it to an existing open or closed group, and remove it from its group.
The group policy, the actions and the chicklet colors are shared through the new
TabGroupMenu.sys.mjsandtab-group-colors.css, so the tab strip, the all tabs panel and Firefox View use one implementation instead of three copies.Closed groups are listed inside the same submenu rather than a nested one, because a
panel-listnested two levels deep resolves its owning panel to the outermost list.Tests:
browser_opentabs_firefoxview.jscovers the new items, including the groups-disabled case. Also verified againstbrowser_tab_groups_tabContextMenu.js,browser_tab_groups.js,browser_tab_groups_telemetry.js,browser_tab_manager_groups.jsandbrowser_tab_group_menu.js.One intentional pixel change: with
browser.nova.enabled, Firefox View now draws the gray chicklet in the same color as the tab strip.Made with Cursor
Lando: link
Bugzilla: bug 2076116
🚫 This pull request has 1 blocker.