Repository navigation
Bug 2069726 - Show the remote control stripe on the address bar only - #373
Closed
jkramer5103 wants to merge 1 commit into
Closed
jkramer5103 wants to merge 1 commit into
jkramer5103 wants to merge 1 commit into
Conversation
No Taskcluster jobs started for this pull requestThe |
Contributor
|
(Automated Close) Please do not file pull requests here, see https://firefox-source-docs.mozilla.org/contributing/how_to_submit_a_patch.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Firefox runs under remote control, the shared
.urlbar-backgroundselector also paints the red diagonal stripe on the separate toolbar search bar. Scope the rule inbrowser/themes/shared/urlbar.cssto#urlbar > .urlbar-backgroundso the indicator appears only on the address bar, as requested in bug 2069726.Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=2069726
Validation:
./mach lint -l stylelint browser/themes/shared/urlbar.csspassed with 0 problems.git diff --checkpassed../mach run --marionettewith the separate search bar enabled, confirm the search bar is unstriped, and check the address bar unfocused, focused, and with results open. No Firefox build is available in this environment.Mozilla's documented Firefox review workflow uses Phabricator. This GitHub PR provides the requested patch; Phabricator submission was not possible because Mozilla review credentials are unavailable in this environment.
Lando: link
Bugzilla: bug 2069726
🚫 This pull request has 1 blocker.