Repository navigation
alerts: stop missing_from_tc for retired pools and macs out of Puppet - #166
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m4-117 kept showing missing_from_tc after gecko-1-b-osx-arm64-vms-host was retired, and m4-81 (the reprovision runner) shows it while sitting in the loaner MDM group. The alert checks now skip hosts that don't count toward a pool (retired pools, loaner/defective MDM groups), and macs pulled from inventory.d no longer stay alerting because of a stale tc_worker_pool_id.
Also adds "Loaner - Nosleep Profile Only" to the excluded MDM groups. It's the only loaner group left in SimpleMDM, so the existing loaner exclusion wasn't matching anything (m4-81, 119, 125, 126, 127, m2-43).