refactor issues and reporting to handle lint and build issues - #3697

[taskcluster 2026-10-06T20:20:26.119Z] Worker Type (code-analysis-1/linux-gw-gcp) settings:
[taskcluster 2026-10-06T20:20:26.120Z]   {
[taskcluster 2026-10-06T20:20:26.120Z]     "config": {
[taskcluster 2026-10-06T20:20:26.120Z]       "deploymentId": ""
[taskcluster 2026-10-06T20:20:26.120Z]     },
[taskcluster 2026-10-06T20:20:26.120Z]     "generic-worker": {
[taskcluster 2026-10-06T20:20:26.120Z]       "engine": "multiuser",
[taskcluster 2026-10-06T20:20:26.120Z]       "go-arch": "amd64",
[taskcluster 2026-10-06T20:20:26.120Z]       "go-os": "linux",
[taskcluster 2026-10-06T20:20:26.120Z]       "go-version": "go1.22.2",
[taskcluster 2026-10-06T20:20:26.120Z]       "release": "https://github.com/taskcluster/taskcluster/releases/tag/v64.3.0",
[taskcluster 2026-10-06T20:20:26.120Z]       "revision": "b66b6614b9b79077f1bfc78f97afb8c25c0c4b30",
[taskcluster 2026-10-06T20:20:26.120Z]       "source": "https://github.com/taskcluster/taskcluster/commits/b66b6614b9b79077f1bfc78f97afb8c25c0c4b30",
[taskcluster 2026-10-06T20:20:26.120Z]       "version": "64.3.0"
[taskcluster 2026-10-06T20:20:26.120Z]     },
[taskcluster 2026-10-06T20:20:26.120Z]     "image": "projects/taskcluster-imaging/global/images/gw-fxci-gcp-l1-gui-googlecompute-2024-08-22t22-48-09z",
[taskcluster 2026-10-06T20:20:26.120Z]     "instance-id": "7329335150752884824",
[taskcluster 2026-10-06T20:20:26.120Z]     "instance-type": "projects/887720501152/machineTypes/c2-standard-4",
[taskcluster 2026-10-06T20:20:26.120Z]     "local-ipv4": "10.128.6.63",
[taskcluster 2026-10-06T20:20:26.120Z]     "project-id": "fxci-production-level1-workers",
[taskcluster 2026-10-06T20:20:26.120Z]     "public-hostname": "code-analysis-1-linux-gw-gcp-ireyqb-mqpemr1lhvvgg7a.c.fxci-production-level1-workers.internal",
[taskcluster 2026-10-06T20:20:26.120Z]     "public-ipv4": "34.171.236.148",
[taskcluster 2026-10-06T20:20:26.120Z]     "region": "us-central1",
[taskcluster 2026-10-06T20:20:26.120Z]     "zone": "us-central1-f"
[taskcluster 2026-10-06T20:20:26.120Z]   }
[taskcluster 2026-10-06T20:20:26.120Z] Task ID: CORARi44QvKmI6FeB36vyw
[taskcluster 2026-10-06T20:20:26.120Z] === Task Starting ===
[taskcluster:warn 2026-10-06T20:20:26.122Z] This task was designed to run under Docker Worker. Docker Worker is no longer maintained.
[taskcluster:warn 2026-10-06T20:20:26.122Z] In order to execute this task, it is being converted to a Generic Worker task, using the D2G
[taskcluster:warn 2026-10-06T20:20:26.122Z] utility (Docker Worker 2 Generic Worker):
[taskcluster:warn 2026-10-06T20:20:26.122Z]     https://github.com/taskcluster/taskcluster/tree/main/clients/client-shell#translating-docker-worker-task-definitionpayload-to-generic-worker-task-definitionpayload
[taskcluster:warn 2026-10-06T20:20:26.122Z] 
[taskcluster:warn 2026-10-06T20:20:26.122Z] We recommend that you convert all your Docker Worker tasks to Generic Worker tasks, to ensure
[taskcluster:warn 2026-10-06T20:20:26.122Z] continued support. For this task, see the converted payload below. If you have many tasks that
[taskcluster:warn 2026-10-06T20:20:26.122Z] require conversion, consider using the d2g tool (above) directly. It simply takes a Docker
[taskcluster:warn 2026-10-06T20:20:26.122Z] Worker task payload as input, and outputs a Generic Worker task payload. It can also convert
[taskcluster:warn 2026-10-06T20:20:26.122Z] Docker Worker scopes to equivalent Generic Worker scopes.
[taskcluster:warn 2026-10-06T20:20:26.122Z] 
[taskcluster:warn 2026-10-06T20:20:26.123Z] Converted task definition (conversion performed by d2g):
[taskcluster:warn 2026-10-06T20:20:26.123Z] ---
[taskcluster:warn 2026-10-06T20:20:26.123Z]   created: "2026-10-06T20:19:04.034Z"
[taskcluster:warn 2026-10-06T20:20:26.123Z]   deadline: "2026-10-06T21:19:04.034Z"
[taskcluster:warn 2026-10-06T20:20:26.123Z]   dependencies: []
[taskcluster:warn 2026-10-06T20:20:26.123Z]   expires: "2027-10-06T21:19:04.034Z"
[taskcluster:warn 2026-10-06T20:20:26.123Z]   extra: {}
[taskcluster:warn 2026-10-06T20:20:26.123Z]   metadata:
[taskcluster:warn 2026-10-06T20:20:26.123Z]     description: Check code style with pre-commit hooks
[taskcluster:warn 2026-10-06T20:20:26.123Z]     name: 'Code Review Bot checks: linting'
[taskcluster:warn 2026-10-06T20:20:26.123Z]     owner: bastien@mozilla.com
[taskcluster:warn 2026-10-06T20:20:26.123Z]     source: https://github.com/mozilla/code-review
[taskcluster:warn 2026-10-06T20:20:26.123Z]   payload:
[taskcluster:warn 2026-10-06T20:20:26.123Z]     command:
[taskcluster:warn 2026-10-06T20:20:26.123Z]     - - bash
[taskcluster:warn 2026-10-06T20:20:26.123Z]       - -cx
[taskcluster:warn 2026-10-06T20:20:26.123Z]       - podman run -t --rm --privileged -e RUN_ID -e TASKCLUSTER_ROOT_URL -e TASKCLUSTER_WORKER_LOCATION
[taskcluster:warn 2026-10-06T20:20:26.123Z]         -e TASK_ID 'python:3.12' sh -lxce 'git clone --quiet https://github.com/bhearsum/code-review
[taskcluster:warn 2026-10-06T20:20:26.123Z]         /src && cd /src && git checkout 53cf15b6489d842aebf90fa20974b88a972c9309 -b
[taskcluster:warn 2026-10-06T20:20:26.123Z]         checks && cd /src/bot && pip install --disable-pip-version-check --no-cache-dir
[taskcluster:warn 2026-10-06T20:20:26.123Z]         --quiet -r requirements-dev.txt && cd /src && pre-commit run -a --show-diff-on-failure'
[taskcluster:warn 2026-10-06T20:20:26.123Z]     features:
[taskcluster:warn 2026-10-06T20:20:26.123Z]       backingLog: true
[taskcluster:warn 2026-10-06T20:20:26.123Z]       liveLog: true
[taskcluster:warn 2026-10-06T20:20:26.123Z]     logs:
[taskcluster:warn 2026-10-06T20:20:26.123Z]       backing: public/logs/live_backing.log
[taskcluster:warn 2026-10-06T20:20:26.123Z]       live: public/logs/live.log
[taskcluster:warn 2026-10-06T20:20:26.123Z]     maxRunTime: 3600
[taskcluster:warn 2026-10-06T20:20:26.123Z]     onExitStatus:
[taskcluster:warn 2026-10-06T20:20:26.123Z]       retry:
[taskcluster:warn 2026-10-06T20:20:26.123Z]       - 125
[taskcluster:warn 2026-10-06T20:20:26.123Z]       - 128
[taskcluster:warn 2026-10-06T20:20:26.123Z]   priority: lowest
[taskcluster:warn 2026-10-06T20:20:26.123Z]   projectId: none
[taskcluster:warn 2026-10-06T20:20:26.123Z]   provisionerId: code-analysis-1
[taskcluster:warn 2026-10-06T20:20:26.123Z]   requires: all-completed
[taskcluster:warn 2026-10-06T20:20:26.123Z]   retries: 5
[taskcluster:warn 2026-10-06T20:20:26.123Z]   routes:
[taskcluster:warn 2026-10-06T20:20:26.123Z]   - checks
[taskcluster:warn 2026-10-06T20:20:26.123Z]   schedulerId: taskcluster-github
[taskcluster:warn 2026-10-06T20:20:26.123Z]   scopes: []
[taskcluster:warn 2026-10-06T20:20:26.123Z]   tags: {}
[taskcluster:warn 2026-10-06T20:20:26.123Z]   taskGroupId: bRFt5faCTx6hSE31Y_3YrA
[taskcluster:warn 2026-10-06T20:20:26.123Z]   taskQueueId: code-analysis-1/linux-gw-gcp
[taskcluster:warn 2026-10-06T20:20:26.123Z]   workerType: linux-gw-gcp
[taskcluster:warn 2026-10-06T20:20:26.123Z] 
[taskcluster 2026-10-06T20:20:26.621Z] Uploading redirect artifact public/logs/live.log to URL https://firefoxci-websocktunnel.services.mozilla.com/us-central1-f.7329335150752884824.60099/log/OmDFYBZ4R3OKejoDtmhVnA with mime type "text/plain; charset=utf-8" and expiry 2026-10-06T21:35:26.504Z
[taskcluster 2026-10-06T20:20:26.743Z] Executing command 0: bash -cx 'podman run -t --rm --privileged -e RUN_ID -e TASKCLUSTER_ROOT_URL -e TASKCLUSTER_WORKER_LOCATION -e TASK_ID '\''python:3.12'\'' sh -lxce '\''git clone --quiet https://github.com/bhearsum/code-review /src && cd /src && git checkout 53cf15b6489d842aebf90fa20974b88a972c9309 -b checks && cd /src/bot && pip install --disable-pip-version-check --no-cache-dir --quiet -r requirements-dev.txt && cd /src && pre-commit run -a --show-diff-on-failure'\'
+ podman run -t --rm --privileged -e RUN_ID -e TASKCLUSTER_ROOT_URL -e TASKCLUSTER_WORKER_LOCATION -e TASK_ID python:3.12 sh -lxce 'git clone --quiet https://github.com/bhearsum/code-review /src && cd /src && git checkout 53cf15b6489d842aebf90fa20974b88a972c9309 -b checks && cd /src/bot && pip install --disable-pip-version-check --no-cache-dir --quiet -r requirements-dev.txt && cd /src && pre-commit run -a --show-diff-on-failure'
Resolved "python" as an alias (/etc/containers/registries.conf.d/shortnames.conf)
Trying to pull docker.io/library/python:3.12...
Getting image source signatures
Copying blob sha256:99ceb936471fed91d914bcb7d31780d10aef96197ae1ce69bf7dbd108cf96521
Copying blob sha256:62fe2e747f69f2f414c7e9eb1553155cf0a658398f0462557f458821dce2b29d
Copying blob sha256:4846f29007305297af653c57bf9b60ba8f676a38695c68d98460063442581671
Copying blob sha256:ee0642b8714bc9f14387af26100d2c0bcbb301e85fcaf9834364f7166323ba81
Copying blob sha256:4dc3950125ebc9ed195e1101fc6c02e2fce113ba0f53bfb05b2cdf58747df9af
Copying blob sha256:b2eb680928d477abf960adfa8bb00fa681dac38ca5f624850072ed2976a80607
Copying blob sha256:4dc3950125ebc9ed195e1101fc6c02e2fce113ba0f53bfb05b2cdf58747df9af
Copying blob sha256:99ceb936471fed91d914bcb7d31780d10aef96197ae1ce69bf7dbd108cf96521
Copying blob sha256:ee0642b8714bc9f14387af26100d2c0bcbb301e85fcaf9834364f7166323ba81
Copying blob sha256:b2eb680928d477abf960adfa8bb00fa681dac38ca5f624850072ed2976a80607
Copying blob sha256:62fe2e747f69f2f414c7e9eb1553155cf0a658398f0462557f458821dce2b29d
Copying blob sha256:4846f29007305297af653c57bf9b60ba8f676a38695c68d98460063442581671
Copying blob sha256:1d5ee7e42ed8b29a45f8c80036ae3b275419382ad477bdba0b54acd6b04b7ac9
Copying blob sha256:1d5ee7e42ed8b29a45f8c80036ae3b275419382ad477bdba0b54acd6b04b7ac9
Copying config sha256:720762d97dcd513c0e9e578cbc6cd97bb633f8f9e268ef75b73fd4f4621ea200
Writing manifest to image destination
Storing signatures
+ id -u
+ [ 0 -eq 0 ]
+ PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
+ export PATH
+ [ #  ]
+ [  ]
+ id -u
+ [ 0 -eq 0 ]
+ PS1=# 
+ [ -d /etc/profile.d ]
+ run-parts --list --regex ^[a-zA-Z0-9_][a-zA-Z0-9._-]*\.sh$ /etc/profile.d
+ unset i
+ [  ]
+ git clone --quiet https://github.com/bhearsum/code-review /src
+ cd /src
+ git checkout 53cf15b6489d842aebf90fa20974b88a972c9309 -b checks
Switched to a new branch 'checks'
+ cd /src/bot
+ pip install --disable-pip-version-check --no-cache-dir --quiet -r requirements-dev.txt
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager, possibly rendering your system unusable. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv. Use the --root-user-action option if you know what you are doing and want to suppress this warning.
+ cd /src
+ pre-commit run -a --show-diff-on-failure
[INFO] Initializing environment for https://github.com/astral-sh/ruff-pre-commit.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-prettier.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-prettier:prettier@2.7.1.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/codespell-project/codespell.
[INFO] Initializing environment for https://github.com/marco-c/taskcluster_yml_validator.
[INFO] Initializing environment for https://github.com/asottile/yesqa.
[INFO] Initializing environment for https://github.com/adamchainz/django-upgrade.
[INFO] Installing environment for https://github.com/astral-sh/ruff-pre-commit.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/mirrors-prettier.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/codespell-project/codespell.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/marco-c/taskcluster_yml_validator.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/asottile/yesqa.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/adamchainz/django-upgrade.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
ruff.....................................................................Passed
ruff-format..............................................................Passed
prettier.................................................................Passed
check python ast.........................................................Passed
check docstring is first.................................................Passed
check that executables have shebangs.....................................Passed
check for merge conflicts................................................Passed
check for broken symlinks............................(no files to check)Skipped
debug statements (python)................................................Passed
trim trailing whitespace.................................................Passed
check yaml...............................................................Passed
mixed line ending........................................................Passed
python tests naming......................................................Passed
check json...............................................................Passed
fix requirements.txt.....................................................Passed
check vcs permalinks.....................................................Passed
codespell................................................................Passed
taskcluster_yml..........................................................Passed
Strip unnecessary `# noqa`s..............................................Passed
Check for useless excludes...............................................Passed
django-upgrade...........................................................Passed
[taskcluster 2026-10-06T20:21:28.733Z]    Exit Code: 0
[taskcluster 2026-10-06T20:21:28.733Z]    User Time: 25.781989s
[taskcluster 2026-10-06T20:21:28.733Z]  Kernel Time: 4.95505s
[taskcluster 2026-10-06T20:21:28.733Z]    Wall Time: 1m1.990361104s
[taskcluster 2026-10-06T20:21:28.733Z]       Result: SUCCEEDED
[taskcluster 2026-10-06T20:21:28.733Z] === Task Finished ===
[taskcluster 2026-10-06T20:21:28.734Z] Task Duration: 1m1.990811344s
[taskcluster 2026-10-06T20:21:28.875Z] Uploading link artifact public/logs/live.log to artifact public/logs/live_backing.log with expiry 2027-10-06T21:19:04.034Z