Skip to content

chore(project): split Desktop Nimbus UI into single-worker jobs - #17148

Merged
yashikakhurana merged 6 commits into
mainfrom
17132
Sep 24, 2026
Merged

yashikakhurana merged 6 commits into
mainfrom
17132

Conversation

@jaredlockhart

@jaredlockhart jaredlockhart commented Sep 4, 2026 •

Copy link
Copy Markdown
Collaborator

Because

  • Kinto allows one pending review per collection, so several xdist workers
    driving one Kinto instance contend for a single shared resource
  • --dist loadgroup only pins tests that declare a Kinto fixture directly, so
    tests that reach Kinto through the selenium fixture were never grouped
  • the split hook ran ahead of pytest's own mark filtering, so it divided the
    whole integration suite rather than the tests the job selects

This commit

  • Runs integration-nimbus-ui as a matrix of four single-worker jobs, each with
    its own container stack and therefore its own Kinto
  • Removes the xdist_group tagging from the integration conftest, now that no
    job passes --dist loadgroup
  • Runs the split last so each shard holds an equal share of the selected tests

Fixes #17132

Because

* Kinto allows one pending review per collection, so several xdist workers
  driving one Kinto instance contend for a single shared resource
* `--dist loadgroup` only pins tests that declare a Kinto fixture directly, so
  tests that reach Kinto through the `selenium` fixture were never grouped

This commit

* Runs `integration-nimbus-ui` as a matrix of four single-worker jobs, each with
  its own container stack and therefore its own Kinto
* Removes the `xdist_group` tagging from the integration conftest, now that no
  job passes `--dist loadgroup`

Fixes #17132
…kers

Because

* the split hook ran ahead of pytest's own mark filtering, so it divided the
  whole integration suite rather than the tests the job selects
* that left the four shards holding unequal numbers of nimbus_ui tests

This commit

* runs the split last so each shard holds an equal share of the selected tests
# Conflicts:
#	.github/workflows/ci.yml

@yashikakhurana yashikakhurana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets cut the time, thank you @jaredlockhart

@jaredlockhart
jaredlockhart added this pull request to the merge queue Sep 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 23, 2026
@yashikakhurana
yashikakhurana added this pull request to the merge queue Sep 24, 2026
Merged via the queue into main with commit 5a0e788 Sep 24, 2026
35 checks passed
@yashikakhurana
yashikakhurana deleted the 17132 branch September 24, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Isolate integration test Kinto concurrency by splitting nimbus_ui into single-worker jobs

2 participants