perf(nimbus): compute rollout review errors once per render - #17152
Merged
Merged
Conversation
jaredlockhart
force-pushed
the
17151
branch
2 times, most recently
from
September 4, 2026 19:31
cb907f1 to
d78937a
Compare
jaredlockhart
changed the title
Because * Rendering a rollout page runs eleven full rollout review validation passes. * The sidebar reads the review error state ten times and the setup progress computes it again. This commit * Computes the rollout review errors once in the shared setup-progress context and has the sidebar read that, rather than each template reference recomputing them. * Adds the setup-progress context to the archive toggle view, which also renders the sidebar. Fixes #17151
jaredlockhart
marked this pull request as ready for review
September 10, 2026 20:28
jaredlockhart
requested review from
RJAK11,
freshstrangemusic,
mikewilli and
yashikakhurana
as code owners
September 10, 2026 20:28
RJAK11
approved these changes
Sep 10, 2026
RJAK11
left a comment
RJAK11
left a comment
Contributor
There was a problem hiding this comment.
Tested the changes locally and everything seemed to behave correctly and the changes all make sense to me! 🎉
jaredlockhart
enabled auto-merge
September 14, 2026 17:08
Because * The phase factory defaults every phase to start today, so two phases always overlap and fail the rollout review sequence check. * That left the review-valid case of the advance-phase test asserting an enabled button on a rollout that still had review errors. This commit * Pins explicit contiguous start and end dates on both phases so the risk_brand value is the only thing the two cases differ on.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #17151