feat(nimbus): warn on deprecated fxms-message placeholder features - #17154
Merged
Merged
Conversation
Because * The numbered fxms-message placeholder features cannot co-enroll with other deliveries. * Firefox 152 added a single co-enrolling fxms-message feature that replaces them. This commit * Warns when a desktop delivery uses a numbered placeholder and every targeted version supports the co-enrolling feature. * Determines availability from the feature manifest rather than a hardcoded version. Fixes #17149
Collaborator
Author
|
Local render on a seeded draft desktop experiment attaching The warning appears as a bullet on the existing warning card. It is non-blocking, and it has no Learn more link of its own.
The message is the bullet's own text rather than a hover tooltip, and it names the deprecated feature IDs first and the replacement second. One placeholder reads |
jaredlockhart
marked this pull request as ready for review
September 16, 2026 21:01
jaredlockhart
requested review from
RJAK11,
freshstrangemusic,
mikewilli and
yashikakhurana
as code owners
September 16, 2026 21:01
Because * The instruction to use fxms-message was buried behind the rationale. This commit * Leads the warning with the deprecated feature IDs and the replacement to use. * Picks the verb from the placeholder count so one or several IDs both read correctly. Fixes #17149
RJAK11
approved these changes
Sep 21, 2026
RJAK11
left a comment
RJAK11
left a comment
Contributor
There was a problem hiding this comment.
Tested it locally and it worked well for me!
Because * The deprecation warning's message was only reachable by hovering the card's tooltip, while the card itself showed a short static label. * The message names both the deprecated feature and its replacement, so it is the text a reviewer needs to see without hovering. This commit * Renders the serializer message as the warning card's visible text for the fxms-message deprecation warning. * Drops the tooltip icon for warnings whose message is the visible text. Fixes #17149
# Conflicts: # experimenter/experimenter/experiments/models.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #17149