Skip to content

fix(nimbus): distinguish errored metrics from not-yet-computed metrics on results - #17157

Merged
jaredlockhart merged 6 commits into
mainfrom
17155
Sep 16, 2026
Merged

jaredlockhart merged 6 commits into
mainfrom
17155

Conversation

@jaredlockhart

Copy link
Copy Markdown
Collaborator

Because

  • The results page branches on has_errors or not has_data, so a metric Jetstream failed on and a metric whose analysis window has not run yet render identically.
  • Every weekly and overall outcome metric on a recently launched experiment hits the second state, so the page offers a support-contact banner for an analysis that is working correctly.

This commit

  • Splits the two states in the results template so errors keep the amber warning treatment and the support button.
  • Renders a blue informational state for metrics with no data yet, without a support button.
  • Moves the results availability copy into NimbusUIConstants.
  • Adds view tests covering both states.

Fixes #17155

@jaredlockhart

Copy link
Copy Markdown
Collaborator Author

Local renders on a seeded experiment whose results_data was hand-written so one KPI metric is in v3.errors and another has no valid point estimate.

Both states on one card, so the contrast is visible along with the collapsed header icons:

Error and no-data states side by side

Error state, unchanged from before: amber banner, warning triangle, Contact Experimenter Support button. Header pill shows an amber triangle.

Error state

No-data state, new: blue alert-info, circled-i, "Not available yet", no support button. Header pill shows a blue info icon.

No data available yet state

…s on results

Because

* The results page branches on has_errors or not has_data, so a metric Jetstream failed on and a metric whose analysis window has not run yet render identically.
* Every weekly and overall outcome metric on a recently launched experiment hits the second state, so the page offers a support-contact banner for an analysis that is working correctly.

This commit

* Splits the two states in the results template so errors keep the amber warning treatment and the support button.
* Renders a blue informational state for metrics with no data yet, without a support button.
* Moves the results availability copy into NimbusUIConstants.
* Adds view tests covering both states.

Fixes #17155
@jaredlockhart
jaredlockhart marked this pull request as ready for review September 9, 2026 19:20

@RJAK11 RJAK11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jaredlockhart
jaredlockhart added this pull request to the merge queue Sep 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 14, 2026
Because

* The RETENTION constant was split into fixed weekly metrics on main, so the results state tests fail with an AttributeError.

This commit

* Points the results state test fixtures at RETENTION_WEEK_2.
@jaredlockhart
jaredlockhart added this pull request to the merge queue Sep 16, 2026
Merged via the queue into main with commit 5c04498 Sep 16, 2026
32 checks passed
@jaredlockhart
jaredlockhart deleted the 17155 branch September 16, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Results page renders 'metric errored' and 'metric not computed yet' identically

2 participants