fix(nimbus): distinguish errored metrics from not-yet-computed metrics on results - #17157
Merged
Merged
Conversation
Collaborator
Author
|
Local renders on a seeded experiment whose Both states on one card, so the contrast is visible along with the collapsed header icons: Error state, unchanged from before: amber banner, warning triangle, Contact Experimenter Support button. Header pill shows an amber triangle. No-data state, new: blue |
…s on results Because * The results page branches on has_errors or not has_data, so a metric Jetstream failed on and a metric whose analysis window has not run yet render identically. * Every weekly and overall outcome metric on a recently launched experiment hits the second state, so the page offers a support-contact banner for an analysis that is working correctly. This commit * Splits the two states in the results template so errors keep the amber warning treatment and the support button. * Renders a blue informational state for metrics with no data yet, without a support button. * Moves the results availability copy into NimbusUIConstants. * Adds view tests covering both states. Fixes #17155
jaredlockhart
marked this pull request as ready for review
September 9, 2026 19:20
jaredlockhart
requested review from
RJAK11,
freshstrangemusic,
mikewilli and
yashikakhurana
as code owners
September 9, 2026 19:20
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 14, 2026
jaredlockhart
enabled auto-merge
September 16, 2026 16:26
Because * The RETENTION constant was split into fixed weekly metrics on main, so the results state tests fail with an AttributeError. This commit * Points the results state test fixtures at RETENTION_WEEK_2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Because
This commit
Fixes #17155