Conversation
RJAK11
requested review from
freshstrangemusic,
jaredlockhart,
mikewilli and
yashikakhurana
as code owners
September 9, 2026 20:37
Contributor
Author
Screen.Recording.2026-09-09.at.4.33.09.PM.mov |
jaredlockhart
previously requested changes
Sep 10, 2026
… page Because: - the new rollout detail page read `experiment.kinto_collection` to decide whether to show the secure collection callout, so a rollout whose features publish to different Remote Settings collections (e.g. prefFlips and abouthomecache) returned a 500 This commit: - treats that case as not secure so the page renders and reports the conflict through the existing review validation on the Features card which keeps preview and launch blocked Fixes #17116
yashikakhurana
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
experiment.kinto_collectionto decide whether to show the secure collection callout, so a rollout whose features publish to different Remote Settings collections (e.g. prefFlips and abouthomecache) returned a 500This commit:
Fixes #17116