feat(nimbus): add reviewers, editors, jetstream error counts, and conclusion recommendations to reports - #17250
Merged
Merged
Conversation
…clusion recommendations to reports Because * The CSV and YAML report consumers need to know who reviewed and who edited each experiment * Jetstream analysis error counts and the full takeaways set were only visible in the UI This commit * Adds NimbusExperiment convenience properties for reviewer emails, editor emails, and jetstream error counts * Adds those fields plus the remaining takeaways fields to the CSV and YAML report serializers * Prefetches changelogs with experiment_data deferred on both report querysets Fixes #17249
jaredlockhart
marked this pull request as ready for review
September 10, 2026 16:24
jaredlockhart
requested review from
RJAK11,
freshstrangemusic,
mikewilli and
yashikakhurana
as code owners
September 10, 2026 16:24
jaredlockhart
enabled auto-merge
September 10, 2026 16:24
mikewilli
reviewed
Sep 10, 2026
| "type": "string", | ||
| "readOnly": true | ||
| }, | ||
| "jetstream_errors_count": { |
Contributor
There was a problem hiding this comment.
Small suggestion: it might make sense to name this analysis_errors_count so that it's more self-explanatory, and so it doesn't have to change when we're getting results from highwind.
Collaborator
Author
There was a problem hiding this comment.
oh good idea
Because * The report fields should not name the specific analysis backend * The name will not need to change when results come from highwind This commit * Renames the jetstream_errors properties and report fields to analysis_errors
yashikakhurana
approved these changes
Sep 14, 2026
yashikakhurana
left a comment
yashikakhurana
left a comment
Contributor
There was a problem hiding this comment.
More data, fun, thank you @jaredlockhart
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #17249