feat(nimbus): Add targeting for closed-browser web notifications - #17256
Merged
RJAK11 merged 2 commits intoSep 16, 2026
Merged
Conversation
Because: - The Closed-Browser Web Notifications Delivery experiment targets Windows 10+ users with profiles 28+ days old, non-enterprise, who have allowed at least one origin to send notifications - An experiment can only select one advanced targeting config, so the criteria need to be composed into a single config - Bug 2069104 adds the allowedNotificationOrigins targeting attribute that the notifications clause depends on This commit: - Adds has_allowed_notifications, a reusable config for users who have granted notification permission to at least one origin - Adds cbwn_delivery_established_profiles for the experiment itself, composing PROFILE28DAYS, NO_ENTERPRISE and has_allowed_notifications - Marks allowedNotificationOrigins as untranslatable for BigQuery, since it is not yet recorded to the Glean targeting context - Preserves allowedNotificationOrigins as a known targeting field until the recorded targeting context manifest picks it up from Bug 2069104 Once Bug 2069104 rides out and the External Configs bot syncs the manifest, the preserved-keys entry should be dropped and allowedNotificationOrigins moved from KNOWN_UNTRANSLATABLE into JEXL_TO_BQ_COLUMN to enable audience sizing for these configs. Fixes mozilla#17251
halemu
requested review from
RJAK11,
freshstrangemusic,
jaredlockhart,
mikewilli and
yashikakhurana
as code owners
September 10, 2026 20:13
halemu
marked this pull request as draft
September 10, 2026 20:13
jaredlockhart
approved these changes
Sep 10, 2026
| "attachedFxAOAuthClients", | ||
| # Remove once the recorded targeting context manifest includes this | ||
| # attribute (Bug 2069104). | ||
| "allowedNotificationOrigins", |
Collaborator
There was a problem hiding this comment.
Awesome thnx for linking the relevant bug 🙏
yashikakhurana
marked this pull request as ready for review
September 14, 2026 15:50
yashikakhurana
marked this pull request as draft
September 14, 2026 15:50
Contributor
|
@halemu can I mark this ready for review? |
halemu
marked this pull request as ready for review
September 15, 2026 14:10
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 15, 2026
Contributor
Author
|
Hi @yashikakhurana Could this be merged now? Thanks! |
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
Fixes #17251