Build fix for Clang compilers - #96
Open
ercansormaz wants to merge 1 commit into
Open
ercansormaz wants to merge 1 commit into
ercansormaz wants to merge 1 commit into
Conversation
Signed-off-by: Ercan SORMAZ <ercansormaz@gmail.com>
kpchoi
reviewed
Sep 9, 2026
kpchoi
left a comment
Owner
There was a problem hiding this comment.
Thanks for the fix. However, I think the changes need another review before merging:
CMAKE_CXX_COMPILER_IDis used forCMAKE_C_FLAGS; this should likely useCMAKE_C_COMPILER_ID.AppleClangis not covered by theClangcondition, although the reported issue occurs with AppleClang.-Wno-shift-overflowis not equivalent to the removed GCC-specific-Wno-stringop-overflow; please verify whether it is actually needed.- Please verify the compiler-specific warning flags for GCC, Clang, and AppleClang separately.
The underlying issue is valid, but I don't think this patch is ready to merge as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I try to build xevd to use in ffmpeg on Intel MacOS Sequoia 15.7.9