Repository navigation
⚡️ Use version-aware Clifford+T synthesis - #1081
Merged
Merged
Conversation
simon1hofmann
force-pushed
the
codex/version-aware-clifford-t
branch
from
October 21, 2026 11:38
78c27d4 to
b496e38
Compare
simon1hofmann
marked this pull request as ready for review
October 21, 2026 11:42
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
burgholzer
approved these changes
Oct 21, 2026
burgholzer
left a comment
Member
There was a problem hiding this comment.
Nice! Just one little detail that can be improved. Feel free to get this in afterwards!
burgholzer
requested changes
Oct 21, 2026
burgholzer
left a comment
Member
There was a problem hiding this comment.
One thing feels a bit weird here.
🤖 *AI text below* 🤖 Reuse native-target preparation and mirror compilation after merging the new target lowering. Cover disconnected native targets and mirrors without measurement capabilities on both synthesis backends. Assisted-by: GPT-5 via Codex
Assisted-by: GPT-5 via Codex
Assisted-by: GPT-5 via Codex
12 tasks done
Assisted-by: GPT-5 via Codex
Assisted-by: GPT-5 via Codex
simon1hofmann
changed the base branch from
main
to
codex/clifford-t-post-synthesis
October 21, 2026 19:28
Assisted-by: GPT-5 via Codex
Assisted-by: GPT-5 via Codex
Pass the target and equivalence library to high-level synthesis so inverse ISWAP and DCX definitions are lowered before basis translation. Cover both gates at every optimization level and sort the changelog reference. Assisted-by: GPT-6 via Codex
Run continuous optimization, Solovay-Kitaev synthesis, and discrete cleanup in one staged pass manager. Disable permutation elision for native circuits so QASM exports preserve wire ordering without manual permutation repair. Reuse only discrete cleanup for exact mirrors and share the final run path. Cover all optimization levels and mirror variants with QASM2/QASM3 permutation round trips. Keep Qiskit 2.2.3 and the synthesis algorithm. Assisted-by: GPT-6 via Codex
burgholzer
force-pushed
the
codex/clifford-t-post-synthesis
branch
from
October 22, 2026 10:17
97f2304 to
e0ab894
Compare
Assisted-by: GPT-6 via Codex
Keep synthesis selection in the staged pipeline and reuse exact cleanup for mirrors. Preserve the inverse-gate and QASM permutation regressions from the prerequisite branch. Assisted-by: GPT-6 via Codex
Signed-off-by: simon1hofmann <119581649+simon1hofmann@users.noreply.github.com>
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Use Qiskit's
SynthesizeRZRotations(gridsynth) for native Clifford+T compilation on Qiskit 2.4.2 and newer. Keep Solovay–Kitaev on older supported releases, including Qiskit 2.2.3. Select the synthesis pass withpackaging.version.Version, lower RX/RY to RZ, and synthesize rotations inside control-flow blocks.Build on the basis-preserving pipeline merged in #1093. This PR targets
mainand changes only synthesis selection, its dependency, and release notes. It remains a prerequisite for #930's encoding integration.Validation
Clifford+T, mirror, and loop tests pass on Qiskit 2.6.0 and 2.2.3 (103 on each). All lint hooks pass, with type checking on Python 3.14.
Codex assisted with implementation, updates, and checks.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).