Skip to content

✅ Isolate target registry tests - #1090

Merged
simon1hofmann merged 1 commit into
mainfrom
codex/bench-target-test-isolation
Oct 21, 2026
Merged

simon1hofmann merged 1 commit into
mainfrom
codex/bench-target-test-isolation

Conversation

@simon1hofmann

@simon1hofmann simon1hofmann commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 AI text below 🤖

Description

Restore target registries after dynamic and duplicate registration tests. Dummy targets currently leak into later benchmark tests and make results depend on execution order. This change affects tests only. Validation: target and benchmark suites passed together in one process: 386 passed, 4 known expected failures.

Extracted from #1027 so this change can land independently of MQT Core 4.2. Original code authorship is retained.

Validation: Targeted tests and all lint hooks passed. Type checking used Python 3.14.

GPT-6 via Codex assisted with extraction, tests, and this description.

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
  • Every agent-authored or agent-edited public text body begins with the visible disclosure 🤖 *AI text below* 🤖 (titles are exempt).
  • I have disclosed AI assistance in the PR description.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

Extracted from #1027; retain original authorship.

Co-authored-by: Simon Hofmann <simon.t.hofmann@tum.de>
Assisted-by: GPT-6 via Codex
@github-project-automation github-project-automation Bot moved this to In Progress in MQT Applications Oct 21, 2026
@simon1hofmann simon1hofmann added fix Fixes something that isn't working mqt.bench Issues that affect mqt.bench python Pull requests that update Python code tooling Any issue or PR related to project tooling labels Oct 21, 2026
@simon1hofmann simon1hofmann mentioned this pull request Oct 21, 2026
11 of 12 tasks
@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@simon1hofmann
simon1hofmann marked this pull request as ready for review October 21, 2026 14:05
@simon1hofmann

Copy link
Copy Markdown
Collaborator Author

This seems like a trivial fix, will merge it already and update the other PRs.

@simon1hofmann
simon1hofmann merged commit 5a8c254 into main Oct 21, 2026
25 checks passed
@simon1hofmann
simon1hofmann deleted the codex/bench-target-test-isolation branch October 21, 2026 14:54
@github-project-automation github-project-automation Bot moved this from In Progress to Done in MQT Applications Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixes something that isn't working mqt.bench Issues that affect mqt.bench python Pull requests that update Python code tooling Any issue or PR related to project tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants