Skip to content

🐛 Retain mirror provenance across compilation - #1117

Merged
simon1hofmann merged 3 commits into
mainfrom
codex/bench-mirror-provenance
Oct 26, 2026
Merged

simon1hofmann merged 3 commits into
mainfrom
codex/bench-mirror-provenance

Conversation

@simon1hofmann

@simon1hofmann simon1hofmann commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 AI text below 🤖

Description

Compiling a circuit that was already mirrored now preserves mirror=True in its generation metadata and export header. Previously, the default compilation argument overwrote that flag with False, even though the circuit remained a mirror.

The regression test covers all four abstraction levels, checks the output state and exported settings, and verifies that the input metadata stays unchanged. No new dependencies or migration steps.

Validation: full test suite on Qiskit 2.2.3 and 2.6.0 (703 passed and 4 existing expected failures on each); uvx nox -s lint.

AI assistance: Codex helped implement and test these MQT Bench fixes and prepare this description.

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
  • Every agent-authored or agent-edited public text body begins with the visible disclosure 🤖 *AI text below* 🤖 (titles are exempt).
  • I have disclosed AI assistance in the PR description.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

@simon1hofmann simon1hofmann added python Pull requests that update Python code mqt.bench Issues that affect mqt.bench fix Fixes something that isn't working labels Oct 25, 2026
@github-project-automation github-project-automation Bot moved this to In Progress in MQT Applications Oct 25, 2026
@simon1hofmann
simon1hofmann marked this pull request as ready for review October 25, 2026 19:14
@codecov

codecov Bot commented Oct 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@simon1hofmann simon1hofmann self-assigned this Oct 25, 2026
Signed-off-by: simon1hofmann <119581649+simon1hofmann@users.noreply.github.com>
@simon1hofmann
simon1hofmann enabled auto-merge (squash) October 26, 2026 06:45
@simon1hofmann
simon1hofmann merged commit 6e34c57 into main Oct 26, 2026
15 checks passed
@simon1hofmann
simon1hofmann deleted the codex/bench-mirror-provenance branch October 26, 2026 06:51
@github-project-automation github-project-automation Bot moved this from In Progress to Done in MQT Applications Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixes something that isn't working mqt.bench Issues that affect mqt.bench python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants