Skip to content

🐛 Validate benchmark options and custom target filenames - #1118

Merged
simon1hofmann merged 3 commits into
mainfrom
codex/bench-api-input-handling
Oct 26, 2026
Merged

simon1hofmann merged 3 commits into
mainfrom
codex/bench-api-input-handling

Conversation

@simon1hofmann

@simon1hofmann simon1hofmann commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 AI text below 🤖

Description

Report invalid graph-state degrees and negative cardinality depths as argument errors instead of internal tracebacks. Add the supported balanced option to the public type hints, and generate a safe filename component for targets with missing descriptions or path separators.

Extend existing API, CLI, and filename tests. No new dependencies or migration steps.

Validation: full test suite on Qiskit 2.2.3 and 2.6.0 (707 passed and 4 existing expected failures on each); uvx nox -s lint; mypy accepts get_benchmark_alg("dj", 3, balanced=False).

AI assistance: Codex helped implement and test these MQT Bench fixes and prepare this description.

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
  • Every agent-authored or agent-edited public text body begins with the visible disclosure 🤖 *AI text below* 🤖 (titles are exempt).
  • I have disclosed AI assistance in the PR description.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

@simon1hofmann simon1hofmann added python Pull requests that update Python code usability Anything related to usability mqt.bench Issues that affect mqt.bench fix Fixes something that isn't working labels Oct 25, 2026
@github-project-automation github-project-automation Bot moved this to In Progress in MQT Applications Oct 25, 2026
@simon1hofmann
simon1hofmann marked this pull request as ready for review October 25, 2026 19:17
@simon1hofmann simon1hofmann self-assigned this Oct 25, 2026
@codecov

codecov Bot commented Oct 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@burgholzer burgholzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: simon1hofmann <119581649+simon1hofmann@users.noreply.github.com>
@simon1hofmann
simon1hofmann enabled auto-merge (squash) October 26, 2026 06:52
@simon1hofmann
simon1hofmann merged commit b0a59dc into main Oct 26, 2026
15 checks passed
@simon1hofmann
simon1hofmann deleted the codex/bench-api-input-handling branch October 26, 2026 07:03
@github-project-automation github-project-automation Bot moved this from In Progress to Done in MQT Applications Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixes something that isn't working mqt.bench Issues that affect mqt.bench python Pull requests that update Python code usability Anything related to usability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants