Repository navigation
⚡ Speed up HRS and graph-state construction - #1119
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: simon1hofmann <119581649+simon1hofmann@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Build each HRS multiplier's controlled adder once and reuse it for each product bit. Generate graph-state H/CZ gates directly from NetworkX edges, avoiding a dense adjacency matrix and a scan of every potential edge. Preserve the existing node-to-wire mapping and gate order for seeded graphs.
Extend arithmetic coverage with 3 × 3 and compare small seeded graph circuits with Qiskit's adjacency-matrix implementation. No new dependencies or migration steps.
Validation: full test suite on Qiskit 2.2.3 and 2.6.0 (706 passed and 4 existing expected failures on each);
uvx nox -s lint; local construction timing comparisons (median of five runs: about 32× faster for a 129-qubit HRS circuit and 21× faster for a 2,000-qubit graph state). Seeded graph circuits also matched the previous implementation exactly.AI assistance: Codex helped implement and test these MQT Bench fixes and prepare this description.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).