Repository navigation
✨ Add W-state preparation benchmark - #2542
Merged
Merged
Conversation
burgholzer
force-pushed
the
codex/w-state-benchmark
branch
from
September 12, 2026 10:07
53fa37d to
78a7fc6
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
burgholzer
force-pushed
the
codex/w-state-benchmark
branch
from
September 12, 2026 11:10
78a7fc6 to
3b68921
Compare
burgholzer
force-pushed
the
codex/w-state-benchmark
branch
from
September 14, 2026 19:34
3b68921 to
40a4d48
Compare
burgholzer
changed the base branch from
main
to
codex/fix-mlir-exception-boundaries
September 14, 2026 19:53
burgholzer
force-pushed
the
codex/w-state-benchmark
branch
from
September 14, 2026 19:53
40a4d48 to
21d1baa
Compare
Prepare W states in structured loops and evaluate sampled counts against analytic single-excitation probabilities. Register the family in the existing C++, Python, and JSON interfaces. Use main's existing compiler and simulation limits and retain the 4,096-qubit jeff round-trip and DD regression. Assisted-by: Codex
burgholzer
changed the base branch from
codex/fix-mlir-exception-boundaries
to
main
September 23, 2026 11:00
burgholzer
force-pushed
the
codex/w-state-benchmark
branch
from
September 23, 2026 11:00
21d1baa to
eb06b24
Compare
Replace the angle tensor with scalar arithmetic and math operations. Evaluate acos through the existing MLIR folder in the DD interpreter, and remove the table-specific allocation limit and checks. Keep the large jeff round-trip simulation at 1,024 qubits to reduce routine test cost. Retain qubits as the parameter name used by GHZ, QFT, and Multiplexer. Assisted-by: Codex
Member
Author
|
@denialhaag This feels pretty straight-forward and a nice addition to the benchmarks. Also contains a bit of runtime math, which the entire toolchain can now handle 🙌🏼 |
denialhaag
reviewed
Sep 25, 2026
10 tasks done
Assisted-by: GPT-6 Sol via Codex
Assisted-by: GPT-6 Sol via Codex
denialhaag
added this pull request to stack #2627
September 25, 2026 10:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Add W-state preparation to the existing C++, Python, and CLI benchmark interfaces. The generator keeps its controlled-RY/CX sweep in structured loops and computes each rotation angle inside the loop. The DD interpreter uses MLIR's existing constant folder to evaluate
acos; no angle table is needed. Evaluation reuses the existing probability and counts APIs: each single-excitation outcome has ideal probability1/n.Based directly on current upstream main. This PR contains only the W-state addition, with no RTTI, exception-handling, or shared budget changes. Main already supports the counted loops used here; no changes from #2605 or dependency on #2545 are needed.
The 1,024-qubit regression checks jeff serialization, reload, and amplitudes through the existing DD simulator without dense extraction. Documentation includes executable 3- and 256-qubit examples.
Validation:
Codex assisted implementation, rebasing, validation, and this description.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).