Repository navigation
⚡ Use assertion-free release SDKs - #2678
Merged
Merged
Conversation
burgholzer
added
enhancement
This was referenced Oct 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
12 tasks done
burgholzer
force-pushed
the
codex/release-phase1
branch
from
October 6, 2026 13:27
44a6df2 to
5fd1249
Compare
burgholzer
marked this pull request as ready for review
October 7, 2026 12:24
burgholzer
force-pushed
the
codex/release-phase1
branch
from
October 7, 2026 15:54
4e93bf8 to
86b639a
Compare
burgholzer
changed the title
Select exception-enabled Phase 1 SDKs in native wheel workflows and the Linux container installer. Keep development builds and the existing wheel recipe unchanged; PGO, BOLT, and exception removal belong to Phase 2. Assisted-by: GPT-6 via Codex
Use the packaging workflow's assertion-free default and refresh the SDK installer pin. Remove the obsolete MSVC precompiled-header memory limit. Assisted-by: GPT-6 via Codex
Pin workflows, installers, and their manifests to revisions that know LLVM 23.1.2 from release 2026.10.06. Keep development builds on the assert-enabled SDK and release wheels on the noassert companion. Split LLVM's compiler definitions before passing them to CMake. Without this existing Phase 2 fix, nanobind embeds trailing compiler flags into its ABI identifier and the installed wheel cannot import. Quote the sccache version constraint so the shell does not treat it as redirection. Assisted-by: GPT-6 via Codex
Download the installer and its manifest together so Setup selects the matching manifest automatically. Remove the separate manifest URL wiring and refresh the workflow and action pins. Assisted-by: GPT-6 via Codex
Use explicit assertion-free asset URLs from Setup in CI, development, documentation, and release installation paths. Assisted-by: GPT-6 via Codex
Use explicit assertion-free asset URLs from Setup in CI, development, documentation, and release installation paths. Assisted-by: GPT-6 via Codex
Pin the current Setup examples and reusable workflow defaults throughout CI, development, documentation, and release installation paths. Assisted-by: GPT-6 via Codex
Pin Workflows v2.5.1 and setup-mlir v1.5.0 throughout CI, documentation, development containers, and wheel installation. Use cibuildwheel 4.3's fixed Windows argument handling for test dependency groups. Remove the manual install and its redundant smoke-test override. Assisted-by: GPT-6 via Codex
burgholzer
force-pushed
the
codex/release-phase1
branch
from
October 7, 2026 19:40
86b639a to
0fe0e66
Compare
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Use LLVM 23.1.2 from SDK release 2026.10.06 across CI, documentation, development containers, and wheel builds. Release wheels select assertion-free libraries; development builds retain assertions. Pin setup-mlir v1.5.0 and Workflows v2.5.1. Installer source archives keep the script and its version manifest pinned together.
Split LLVM's space-separated compiler definitions before applying them in CMake, so nanobind receives a valid ABI identifier and installed wheels import correctly. Remove the obsolete MSVC
/Zm10option and quote the shell's sccache version constraint.Workflows v2.5.1 supplies cibuildwheel 4.3, whose Windows argument-handling fix allows the shared test dependency group to replace the manual
uv pip installworkaround. Remove its redundant emptybefore-testoverride too. Linux retains its QIR-runner exclusion, and Windows ARM/free-threaded builds retain their import smoke tests.Core's exception migration remains in #2545; PGO and BOLT remain in #2476.
Validation of this dependency update:
uvx nox -s lintandgit diff --checkpass.<and>; Windows execution awaits hosted CI.Earlier Linux ARM qualification with the released noassert SDK passed 3,933 native tests and 1,900 installed-wheel Python tests, with one skip in each suite. The installed CMake consumer also built and ran. These suites were not rerun for this configuration-only follow-up; hosted checks are running for the new head.
Earlier Qiskit-main checks failed on an upstream Qiskit header typo. That upstream failure is accepted for this PR; no Core workaround is included.
AI assistance covered implementation, specialist review, and validation.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).