Repository navigation
🐛 Fix DD and QIR inputs and simplify compiler helpers - #2731
Merged
Merged
Conversation
Reject truncated records, invalid node references, and missing vector levels before constructing DD nodes. Preserve matrix level skipping, subnormal weights, the serialization format, and throwing APIs. Assisted-by: GPT-6 via Codex
A zero-qubit DD can still own a nontrivial phase weight. Release that root on interpreter failure just as for states with qubits. Assisted-by: GPT-6 via Codex
Use the executable-path fallback only when the anchor belongs to the main executable. Relative shared-library paths must resolve beside the loaded provider. Assisted-by: GPT-6 via Codex
After reporting a write failure, clear the LLVM stream error so its destructor does not abort instead of returning the existing failure result. Assisted-by: GPT-6 via Codex
Route parser details through the owning MLIR diagnostic so callers receive the cause along with the failing pipeline. Assisted-by: GPT-6 via Codex
Use void for helpers that cannot fail on supported verified IR. Bind QCO yields directly to parent results and retain runtime lookup, range, and arithmetic checks. Assisted-by: GPT-6 via Codex
Let the probability function validate each outcome once and reuse its result for modular-multiplier success scoring. Preserve count overflow, empty-count, and malformed zero-count checks. Assisted-by: GPT-6 via Codex
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Reuse the JSON registry to return a typed benchmark and canonical metadata in one parse. Remove the duplicate generation registry and repeated case-ID hashing without adding an LLVM dependency. Keep exception support enabled for generation so JSON validation errors reach caller handlers with link-time optimization enabled. Assisted-by: GPT-6 via Codex
Verify LLVM modules and reject incompatible calling conventions, return/parameter ABI attributes, and direct runtime call types before JIT execution. Preserve internal conventions, semantic attributes, and the existing throwing runtime contract. Assisted-by: GPT-6 via Codex
burgholzer
force-pushed
the
codex/extract-core-fixes
branch
from
October 10, 2026 11:54
4c4ab07 to
3dfed49
Compare
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Extract nine independently useful fixes and simplifications from #2545 onto
mainafter #2730, with one commit per change:The throwing APIs, optional LLVM/MLIR build, serialization format, and QIR runtime failure policy remain unchanged. The additive benchmark parsing API is documented in its public header. The larger dependency and error-handling migrations stay in #2545; no new dependency is added.
Review retained the existing DD parser and caught an overstrict QIR attribute check: function-level
alignstackremains accepted, with a positive regression. Bug regressions reproduced failures before their fixes. DD changes address record structure and non-finite weights; broader numeric-normalization work is outside this extraction.Validation on Linux AArch64 with LLVM/MLIR 23:
Windows and macOS require hosted CI. Codex assisted with extraction, review, tests, and this description.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).