Repository navigation
♻️ Use LLVM results for compiler Program APIs - #2733
Merged
Merged
Conversation
🤖 *AI text below* 🤖 Return FailureOr and LogicalResult from fallible Program operations and their benchmark generators. Forward MLIR results directly while preserving diagnostics, ownership and Python exception behavior. Update callers, tests and the C++ example, and remove the private boolean linearity wrapper. Assisted-by: Codex
🤖 *AI text below* 🤖 Use HOME/.config when XDG_CONFIG_HOME is unset or empty, as required by the XDG contract. Cover both cases in the registry tests. Assisted-by: Codex
🤖 *AI text below* 🤖 Remove the requested paragraph about empty configuration variables. Assisted-by: Codex
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
burgholzer
enabled auto-merge (squash)
October 10, 2026 17:37
burgholzer
added a commit
that referenced
this pull request
Oct 10, 2026
🤖 *AI text below* 🤖 Record the remaining QIR lifetime, QDMI allocation recovery, Python compatibility, and documentation findings after rebasing on #2733. Keep the proposed fixes separate from the rebase and distinguish passing local suites from the failed documentation build and untested platforms. Assisted-by: GPT-6 via Codex
This was referenced Oct 10, 2026
burgholzer
added a commit
that referenced
this pull request
Oct 10, 2026
🤖 *AI text below* 🤖 Record the remaining QIR lifetime, QDMI allocation recovery, Python compatibility, and documentation findings after rebasing on #2733. Keep the proposed fixes separate from the rebase and distinguish passing local suites from the failed documentation build and untested platforms. Assisted-by: GPT-6 via Codex
burgholzer
added a commit
that referenced
this pull request
Oct 12, 2026
🤖 *AI text below* 🤖 Record the remaining QIR lifetime, QDMI allocation recovery, Python compatibility, and documentation findings after rebasing on #2733. Keep the proposed fixes separate from the rebase and distinguish passing local suites from the failed documentation build and untested platforms. Assisted-by: GPT-6 via Codex
burgholzer
added a commit
that referenced
this pull request
Oct 17, 2026
🤖 *AI text below* 🤖 Record the remaining QIR lifetime, QDMI allocation recovery, Python compatibility, and documentation findings after rebasing on #2733. Keep the proposed fixes separate from the rebase and distinguish passing local suites from the failed documentation build and untested platforms. Assisted-by: GPT-6 via Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Compiler Program APIs currently convert MLIR results to
boolorstd::optional, and callers convert them back. Use LLVM'sLogicalResultandFailureOr<T>directly in fallible Program operations and the benchmark generators that produce Programs. Remove the private boolean linearity wrapper and the OpenQASM binding's optional-to-result conversion.This extracts the independent Program API cleanup from #2545. Ownership, diagnostics, Python APIs, and Python exception categories are preserved. C++ callers must replace boolean or
has_value()checks on these results withfailed()orsucceeded(); the source-tree API example documents this migration.Two separate commits restore the
HOME/.configfallback whenXDG_CONFIG_HOMEis empty and remove the configuration paragraph about empty environment variables. The registry regression covers both unset and empty XDG values.Codex implemented the changes, ran local validation, and performed the requested ponytail review. The review found no actionable correctness or simplification issues.
Validation on Linux aarch64 with GCC 13.3, LLVM/MLIR 23.1, and Python 3.14:
Windows, macOS, and hosted CI results remain to be checked.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).