Repository navigation
♻️ Extract native fixes and simplify test work - #2734
Merged
Merged
Conversation
🤖 *AI text below* 🤖 Parse bare and uppercase imaginary units accepted by DD serialization. Keep the existing numeric parser and subnormal handling. Assisted-by: Codex
🤖 *AI text below* 🤖 Enforce positive allocation sizes in MemoryManager before constructing an empty slab that cannot grow. Cover direct and package callers. Assisted-by: Codex
🤖 *AI text below* 🤖 Handle scalar DDs without dereferencing a terminal node. Reject outcome widths and permutation indices that exceed the recursive representation. Assisted-by: Codex
🤖 *AI text below* 🤖 Close serialized files before checking stream status so buffered write errors reach callers. Retain the existing stream overload contract. Assisted-by: Codex
🤖 *AI text below* 🤖 Evaluate through the existing ParsedBenchmark instance and case ID. Avoid reparsing the envelope and remove duplicate evaluation dispatch while preserving canonical-manifest checks and diagnostic precedence. Assisted-by: Codex
🤖 *AI text below* 🤖 Keep typed QIR parameters in std::array and specialize the interpreter factory using GateTable arity. Preserve ABI validation and semantic tests while removing runtime checks from verified internal paths. Assisted-by: Codex
🤖 *AI text below* 🤖 Run static constructors and destructors with the owning runtime bound. Keep DDSIM capture streams alive and collect records after teardown. Cover direct JIT state and primary/peer destructor output. Assisted-by: Codex
🤖 *AI text below* 🤖 Read the expected entry from the functionality DD already built by the exhaustive multiplier test. Preserve every input and the separate phase, inverse, and workspace oracles. Assisted-by: Codex
🤖 *AI text below* 🤖 Remove an ignored argument from the source-tree MLIR DD adapter and its callers. Package construction and gate validation own the supported wire range; retain those checks and the existing throwing result contract. Assisted-by: Codex
🤖 *AI text below* 🤖 Describe the existing FailureOr result and source-build availability. Keep the guide aligned with Generate.h without migration wording. Assisted-by: Codex
🤖 *AI text below* 🤖 Run the executable DD guide in a temporary directory so rendered SVGs do not enter the documentation source tree. Assisted-by: Codex
🤖 *AI text below* 🤖 The requested worker count is an upper bound. Count teardown output by completed shots so smaller CPU budgets still verify all session output. Repair the plan's accidental Markdown heading exposed by pre-commit. Assisted-by: Codex
burgholzer
enabled auto-merge (squash)
October 10, 2026 21:19
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Extract independently useful fixes and simplifications from #2545 onto current main. Each change has its own commit; this PR does not depend on the exception replacement.
MemoryManager.ParsedBenchmarkfor JSON evaluation, preserving manifest validation and diagnostic order.Core's native throwing APIs remain. Source-tree MLIR callers use
std::arrayfor typed gate parameters and omit the unused adapter width. Result types, diagnostic adapters and exception policy remain in #2545.CI investigation
The reported Windows failure occurred on main:
SamplingRetainsStateWithoutChangingSamplesreached 600 seconds. Successful previous main and #2545 suites took 76.73 and 78.29 seconds, respectively. These snapshots do not show a sustained exception-replacement regression. No root cause for the isolated hang was reproduced; host and worker stacks from a recurrence are still needed.The Shor change preserves every modulus, multiplier, input and control case, plus the separate coherence, inverse and workspace checks. Matched Linux arm64/GCC 13.3 Release binaries, three runs each pinned to CPU 0, gave medians of 13.770 → 13.053 seconds. Ranges overlap (13.666–14.401 versus 12.524–14.211 seconds), so this is not a reliable CI speedup claim. Most duplicate tests previously removed from #2545 were never on main; no further deletion was justified without losing distinct coverage.
Validation
/dev/fullwhere available.Implemented with Codex assistance; human review remains required.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).