Repository navigation
✨ Compile from explicit target descriptions - #2754
Merged
Merged
Conversation
Accept a validated compilation-target attribute through --target and serialize CompilerTarget from Python. Reuse target compilation and payload selection without opening a QDMI device. Diagnose empty target arguments before MLIR parsing and test the Python-to-CLI handoff. Assisted-by: GPT-6 via Codex
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
mqt-cc --targetnow compiles from an explicit#mqt.compilation_targetattribute without opening a QDMI device.CompilerTarget.__str__()supplies that representation from Python. The existing target parser, validation, mapping, synthesis, and payload selection are reused;--payload-specremains required and--qdmi-deviceis mutually exclusive.Extracted independently from the keynote branch (#2685), based directly on
main; no dependency on the other extracted changes. The target-compilation guide includes a complete CLI example and explains snapshot semantics. Review caught an assertion when an empty argument reached MLIR parsing; empty and whitespace-only values now receive the normal invalid-target diagnostic.Validation: eight native CLI checks and all 15 Python CLI tests pass locally, including serialized Python-to-CLI target handoff. Stub regeneration, whole-file C++ lint, and repository lint pass. The two new native target tests fail on upstream before extraction. Independent ponytail review has no unresolved findings. Hosted CI is pending.
AI assistance covered extraction, independent review, regression fixes, validation, and this description within the user-authorized scope. Human acceptance/review remains.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).