Repository navigation
♻️ Read QDMI configuration with LLVM buffers - #2839
Merged
Merged
Conversation
Use one checked file read and preserve provider status codes and source paths. Remove the unused SC istream adapter while retaining the JSON text and filename entry points and existing exception build policy. Cover missing paths and ENOTDIR; validate the extracted change against main independently of the broader native error migration. Co-authored-by: Daniel Haag <121057143+denialhaag@users.noreply.github.com> Signed-off-by: Lukas Burgholzer <burgholzer@me.com> Assisted-by: GPT-6 via Codex
burgholzer
added
c++
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Read QDMI device configuration files with LLVM MemoryBuffer and report file errors through the existing provider status and logging boundary. One checked read replaces the existence check, standard stream handling and diagnostic fallback wrapper. Missing files and paths through a regular file remain NOTFOUND; bundled-file failures remain FATAL.
Remove the unused C++ SC
readJSON(std::istream&, source)overload. Callers use the JSON-text or filename overload. This extraction from #2545 retains the existing exception/RTTI build policy and adds no cross-library error API.Validation: the independently built Clang 23 ThinLTO release passes all 48 SC/provider tests. Removing ENOTDIR handling makes the targeted regression fail; restoring it passes. Repository lint, whole-file C++ lint and independent Ponytail review pass. CI is not monitored; Windows/macOS execution was not performed.
AI assistance: Codex extracted, reviewed and validated this change. Human review remains required.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).