Skip to content

🐛 Preserve DD ownership on allocation failure - #2842

Draft
denialhaag wants to merge 1 commit into
mainfrom
codex/preserve-dd-ownership-main
Draft

denialhaag wants to merge 1 commit into
mainfrom
codex/preserve-dd-ownership-main

Conversation

@denialhaag

@denialhaag denialhaag commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Description

🤖 AI text below 🤖

Keep the input DD and its owned reference unchanged when global-phase application fails to allocate. Register the replacement root before changing the caller's edge.

Frontports the global-phase fix from #2826.

AI notice

This PR and its contents were created with the assistance of GPT-6 Astra via Codex.

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
  • Every agent-authored or agent-edited public text body begins with the visible disclosure 🤖 *AI text below* 🤖 (titles are exempt).
  • I have disclosed AI assistance in the PR description.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

Assisted-by: GPT-6 Astra via Codex
@denialhaag denialhaag self-assigned this Oct 25, 2026
@denialhaag denialhaag added fix Fix for something that isn't working DD Anything related to the DD package c++ Anything related to C++ code labels Oct 25, 2026
@denialhaag denialhaag added this to the v4.2.0 - SC26 milestone Oct 25, 2026
@codecov

codecov Bot commented Oct 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this test addition is really needed...

@denialhaag
denialhaag requested a review from burgholzer October 25, 2026 14:47

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Anything related to C++ code DD Anything related to the DD package fix Fix for something that isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant