Repository navigation
🐛 Preserve bound Qiskit circuit names - #2844
Merged
Merged
Conversation
🤖 *AI text below* 🤖 Qiskit renames copies during parameter binding. Keep the original name so Result.get_counts(original_circuit) finds the backend's result header. Cover dictionary and positional bindings without mutating the input. Assisted-by: Codex
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
burgholzer
enabled auto-merge (squash)
October 25, 2026 14:46
burgholzer
disabled auto-merge
October 25, 2026 14:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Qiskit gives parameter-bound circuit copies a new name. Preserve the input name before preprocessing so
Result.get_counts(original_circuit)works after dictionary or positional backend binding. The input circuit remains unbound and unchanged. This restores the existing result-lookup contract and needs no migration or dependency change.Validation: all 223 Qiskit plugin tests passed independently on Qiskit 2.5.2 and 2.6.1; full repository lint passed. The new lookup assertions fail against the unmodified backend for both backend-binding forms and pass with this fix. Reviewed the binding, preprocessing, job-header and result-lookup paths.
AI assistance: Codex prepared, reviewed and tested this patch. Maintainer review is pending.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).