Skip to content

🐛 Preserve bound Qiskit circuit names - #2844

Merged
burgholzer merged 1 commit into
mainfrom
fix/qiskit-bound-circuit-names
Oct 25, 2026
Merged

burgholzer merged 1 commit into
mainfrom
fix/qiskit-bound-circuit-names

Conversation

@burgholzer

@burgholzer burgholzer commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

🤖 AI text below 🤖

Description

Qiskit gives parameter-bound circuit copies a new name. Preserve the input name before preprocessing so Result.get_counts(original_circuit) works after dictionary or positional backend binding. The input circuit remains unbound and unchanged. This restores the existing result-lookup contract and needs no migration or dependency change.

Validation: all 223 Qiskit plugin tests passed independently on Qiskit 2.5.2 and 2.6.1; full repository lint passed. The new lookup assertions fail against the unmodified backend for both backend-binding forms and pass with this fix. Reviewed the binding, preprocessing, job-header and result-lookup paths.

AI assistance: Codex prepared, reviewed and tested this patch. Maintainer review is pending.

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
  • Every agent-authored or agent-edited public text body begins with the visible disclosure 🤖 *AI text below* 🤖 (titles are exempt).
  • I have disclosed AI assistance in the PR description.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

🤖 *AI text below* 🤖

Qiskit renames copies during parameter binding. Keep the original name so
Result.get_counts(original_circuit) finds the backend's result header.
Cover dictionary and positional bindings without mutating the input.

Assisted-by: Codex
@burgholzer burgholzer added fix Fix for something that isn't working python Anything related to Python code QDMI Anything related to QDMI labels Oct 25, 2026
@burgholzer burgholzer self-assigned this Oct 25, 2026
@codecov

codecov Bot commented Oct 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@burgholzer burgholzer added this to the v4.2.0 - SC26 milestone Oct 25, 2026
@burgholzer
burgholzer enabled auto-merge (squash) October 25, 2026 14:46
@burgholzer
burgholzer disabled auto-merge October 25, 2026 14:51
@burgholzer
burgholzer merged commit 4d2df76 into main Oct 25, 2026
21 of 22 checks passed
@burgholzer
burgholzer deleted the fix/qiskit-bound-circuit-names branch October 25, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fix for something that isn't working python Anything related to Python code QDMI Anything related to QDMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant