Repository navigation
🐛 Expose QDMI if/else in Qiskit targets - #2845
Merged
Merged
Conversation
🤖 *AI text below* 🤖 Map device-advertised if_else to Qiskit's structural instruction instead of discarding it. Keep it out of opaque gate declarations and reuse the existing recursive operation checks. Test distinct outputs from both branches and sampled ensemble estimation. Assisted-by: Codex
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
8 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
The Qiskit bridge discarded
if_elseeven when the QDMI device advertised it, so preflight rejected supported feedback circuits. Map it to Qiskit'sIfElseOpand keep it out of opaque OpenQASM gate declarations. Existing recursive checks still validate branch operations and their physical operands; devices without advertised support still reject control flow. No new execution engine or dependency is required.Validation: all 225 Qiskit plugin tests passed independently on Qiskit 2.5.2 and 2.6.1; full repository lint passed. The new advertised-feedback regression fails against the unmodified backend. The regression observes both branches on distinct output wires, and a sampled-estimator test checks the resulting feedback ensemble. Existing target/serializer documentation remains accurate; no migration is needed.
AI assistance: Codex prepared, reviewed and tested this patch. Maintainer review is pending.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).