Repository navigation
♻️ Use LLVM streams throughout native code - #2846
Open
burgholzer wants to merge 3 commits into
Open
burgholzer wants to merge 3 commits into
burgholzer wants to merge 3 commits into
Conversation
burgholzer
added this pull request to stack #2847
October 25, 2026 14:26
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Replace remaining STL stream I/O and borrow QDMI keys and DD text lines. Build regex patterns once and preserve parsing, ownership and diagnostics contracts. Migrate test fixtures without changing executable permissions. Require the matching LLVM SDK for native CMake consumers, simplify SDK lookup, and enforce the stream policy through focused include checks. Signed-off-by: Lukas Burgholzer <burgholzer@me.com> Assisted-by: GPT-6 via Codex
Propagate LLVM headers through LLVMSupport and let runtime staging own its loader search path. Simplify the native example and stream policy, and use formatv for simple owned diagnostics. Keep the original project path available to isolated wheel tests so they can locate the downloaded SDK. Encode fixture paths as UTF-8 for LLVM on Windows. Check native runtime exceptions alongside their fatal C boundary. Signed-off-by: Lukas Burgholzer <burgholzer@me.com> Assisted-by: GPT-6 via Codex
Put case and builder names in LLVM-formatted scoped traces instead of custom ostream operators. Keep CTest identifiers deterministic with NO_PRETTY_VALUES for affected discovered suites. Ban all STL stream headers in project code and tests, removing the final exception from the hook and contributor guidance. Signed-off-by: Lukas Burgholzer <burgholzer@me.com> Assisted-by: GPT-6 via Codex
burgholzer
force-pushed
the
codex/llvm-streams-followup
branch
from
October 25, 2026 15:56
b0d8064 to
caf5608
Compare
burgholzer
enabled stacked auto-merge (squash)
October 25, 2026 16:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Stacked on #2840, rebased through
f1e45d3c62onto maindedaa13f5f. Replace the remaining production STL streams with LLVM utilities and migrate test fixtures and the documented native consumer.StringRefviews. Construct DD regex patterns once; preserve the grammar, numeric errors, zero-qubit results, and key/value pairing.llvm::formatvand route worker diagnostics through the existing synchronized logger. These diagnostics now use its standard prefix.Runtimecomponent. Remove the optional-SDK branch and the documented SDK-free build assumption. Supply missing header usage requirements onLLVMSupportonce, so downstream consumers need no manual include paths. The runtime staging helper supplies the executable search path.AGENTS.mdand the development policy. One include check forbids all STL stream headers, including in tests. Replace custom GoogleTest stream printers with LLVM-formatted scoped traces; use native GoogleTest parameter indices for deterministic CTest discovery. The obsolete caller-cout-state assertions are removed.No public function signatures change. Owned results remain owned; no stream adapter, parser framework, or exception API is added.
Validation
exportToDotrename in the affected fixtures. All rebased commits have valid signatures; 64 Python DD tests also pass.ostreamandiosfwd.Ponytail review completed. Isolated parser checks support removing one scratch allocation; no end-to-end speedup, live-memory reduction, or peak-RSS reduction is claimed. Validation is local Linux. The published-head Windows test and Linux wheel failures were diagnosed from both architectures and fixed here; platform reruns remain pending. The published-head C++ coverage gate failed at 69.3%. Direct native runtime error checks now supplement the death tests, but worker startup and exception-cleanup diagnostics remain unexercised; the coverage gate is not claimed resolved.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).