Repository navigation
馃悰 Keep Git Qiskit in the nox test process - #1055
Merged
Merged
Conversation
馃 *AI text below* 馃 Use a uv run overlay so project synchronization cannot replace the Git Qiskit build with the locked release before pytest starts. Keep the native MQT DDSIM build setup and normal test sessions unchanged. Remove the unused command hook, lockfile move and base-environment package report. Validate the imported Git provenance inside the test process. Assisted-by: Codex
burgholzer
commented
Oct 25, 2026
burgholzer
left a comment
Member
Author
There was a problem hiding this comment.
@denialhaag Found this randomly while iterating on something else.
This feels very clean, and apparently also more correct. Would you mind rolling this out elsewhere?
Member
I'll add it to the list! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃 AI text below 馃
Description
The Git-Qiskit session installed Qiskit main, but its following
uv runsynchronized the project and restored the locked release before pytest started. Use auv run --withoverlay for the requested Git dependency. Retain the native MQT DDSIM build setup and normal/minimum sessions; remove the unused command hook and the base-environment version report.Validation on Python 3.12:
2.7.0.dev0at73aa14d2b8b423335a72cb1b8f940249029cb7df.2.6.1after the Git install. The project lock remained unchanged.tests-3.12session passed all 119 tests independently.cmake-formatfails inre.Scanneron unchanged CMake files. No hooks were skipped or repository settings changed.The session-specific assertion was run from a temporary test file; it does not belong in the normal package suite, where release Qiskit is expected:
Run it with
uvx nox -s qiskit-3.12 -- /path/to/test_qiskit_git.py -o addopts=''.This is a developer-test correction with no package API, dependency-range or migration change. The session docstring describes the overlay. AI assistance: Codex prepared, reviewed and tested the patch; maintainer review is pending.
Checklist
If PR contains AI-assisted content:
馃 *AI text below* 馃(titles are exempt).