fix(admin): keep JSON snippets readable after save - #2806
Open
poboll wants to merge 1 commit into
Open
Conversation
SafeDep Report SummaryNo dependency changes detected. Nothing to scan. This report is generated by SafeDep Github App |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Root cause
The snippet editor used
JSON.stringify(JSON.parse(raw))during save. That validation step also collapsed valid JSON into a single line, so reopening the snippet lost the readable structure shown in the editor. The structured snippet conversion path already uses two-space indentation, making the two save paths inconsistent.Scope
This addresses the JSON snippet formatting regression reported in #2749. The current Admin writing flow has since been substantially revised, so this PR does not claim to close the separate preview and draft-state reports from that issue.
Verification
pnpm -C apps/admin exec vitest run src/features/snippets/utils/snippets.normalize.test.ts(2 tests passed)pnpm -C apps/admin run typecheckpnpm -C apps/admin run buildgit diff --checkRelated to #2749