feat(space): add TMDB search composer - #2808
Conversation
SafeDep Report Summary
No dependency changes detected. Nothing to scan. This report is generated by SafeDep Github App |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e34f2fdc58
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| contextCandidates = candidates.filter { candidate in | ||
| contextKindFilter == nil || candidate.kind == contextKindFilter | ||
| } |
There was a problem hiding this comment.
For /note, /page, /post, and /recently searches, filtering only the already-limited mixed candidate list can incorrectly show no matches. DatabaseService.findRefCandidates truncates article IDs to size before hydration and then truncates the combined kinds again (apps/core/src/processors/database/database.service.ts:104,150-156), so, for example, twelve matching posts can exclude every matching note before this .note filter runs. Pass the requested kind to the server or otherwise apply it before the shared result limit.
Useful? React with 👍 / 👎.
|
|
||
| var isShowingSlashMenu: Bool { !slashCommands.isEmpty } | ||
| var isShowingComposerPanel: Bool { isShowingSlashMenu || isChoosingContext } | ||
| var selectedLinks: [ComposerLinkPreview] { links.filter(\.isSelected) } |
There was a problem hiding this comment.
When a user taps the remove button for a URL that remains in the composer text, toggleLink only marks it unselected, but this property immediately removes it from the sole link-selection tray. There is then no UI for selecting it again, and even deleting and retyping the same URL does not help because selectionOverrides[url] retains false; the draft will continue publishing that URL without its card. Keep detected-but-unselected links visible or provide another way to reattach them.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
Notes
The local test environment could not perform a live external TMDB request; the request and normalization path is covered by focused Core and SpaceCore tests.