Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/components/RenderConnectStep-test.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -547,9 +547,7 @@ describe('RenderConnectStep', () => {
// NO_ACCOUNTS is a handleable code, so the newer ActionableError view renders
// its specific content (not the legacy LoginError fallback).
expect(screen.getByText('No accounts found')).toBeInTheDocument()
expect(
screen.getByRole('button', { name: /return to institution selection/i }),
).toBeInTheDocument()
expect(screen.getByRole('button', { name: /go back/i })).toBeInTheDocument()
expect(screen.queryByText('New credentials needed')).not.toBeInTheDocument()
})

Expand Down
2 changes: 0 additions & 2 deletions src/const/language/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,6 @@
"Feature not available": "Característica no disponible",
"%1 does not offer this feature. Please contact your representative to explore options.": "%1 no ofrece esta función. Contacte a su representante para explorar las opciones.",
"Log in again": "Inicie sesión nuevamente",
"Connect a different institution": "Conecte una institución diferente",
"No eligible accounts": "No hay cuentas elegibles",
"Required": "Requerido",
"Add financial management?": "¿Añadir gestión financiera?",
Expand All @@ -392,7 +391,6 @@
"%1 now charges a fee for us to access your account data. To avoid passing that cost on to you, we no longer support %1 connections.": "%1 ahora cobra una comisión por acceder a los datos de su cuenta. Para evitar que usted pague ese costo, ya no ofrecemos conexiones con %1.",
"Success!": "¡Éxito!",
"No accounts found": "No se encontraron cuentas",
"Return to institution selection": "Volver a la selección de instituciones",
"Additional permissions needed": "Se necesitan permisos adicionales",
"Review instructions": "Revisar instrucciones",
"Unable to connect": "No se puede conectar",
Expand Down
9 changes: 0 additions & 9 deletions src/const/language/es.po
Original file line number Diff line number Diff line change
Expand Up @@ -1855,10 +1855,6 @@ msgstr ""
msgid "Log in again"
msgstr "Inicie sesión nuevamente"

#: src/views/actionableError/useActionableErrorMap.tsx
msgid "Connect a different institution"
msgstr "Conecte una institución diferente"

#: src/views/actionableError/useActionableErrorMap.tsx
msgid "No eligible accounts"
msgstr "No hay cuentas elegibles"
Expand Down Expand Up @@ -1943,11 +1939,6 @@ msgstr "¡Éxito!"
msgid "No accounts found"
msgstr "No se encontraron cuentas"

#: src/views/demoConnectGuard/DemoConnectGuard.tsx
#: src/views/actionableError/useActionableErrorMap.tsx
msgid "Return to institution selection"
msgstr "Volver a la selección de instituciones"

#: src/views/actionableError/useActionableErrorMap.tsx
msgid "Additional permissions needed"
msgstr "Se necesitan permisos adicionales"
Expand Down
2 changes: 0 additions & 2 deletions src/const/language/frCa.json
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,6 @@
"Feature not available": "Fonctionnalité non disponible",
"%1 does not offer this feature. Please contact your representative to explore options.": "%1 n'offre pas cette fonctionnalité. Veuillez contacter votre représentant pour explorer les options.",
"Log in again": "Connectez-vous à nouveau",
"Connect a different institution": "Mettre en relation un autre établissement",
"No eligible accounts": "Aucun compte admissible",
"Required": "Requis",
"Add financial management?": "Ajouter la gestion financière ?",
Expand All @@ -393,7 +392,6 @@
"%1 now charges a fee for us to access your account data. To avoid passing that cost on to you, we no longer support %1 connections.": "$1 facture désormais des frais pour accéder à vos données de compte. Pour éviter de vous les répercuter, nous ne prenons plus en charge les connexions $1.",
"Success!": "Succès!",
"No accounts found": "Aucun compte trouvé",
"Return to institution selection": "Retour à la sélection des établissements",
"Additional permissions needed": "Autorisations supplémentaires nécessaires",
"Review instructions": "Instructions de révision",
"Unable to connect": "Impossible de se connecter",
Expand Down
9 changes: 0 additions & 9 deletions src/const/language/frCa.po
Original file line number Diff line number Diff line change
Expand Up @@ -1931,10 +1931,6 @@ msgstr ""
msgid "Log in again"
msgstr "Connectez-vous à nouveau"

#: src/views/actionableError/useActionableErrorMap.tsx
msgid "Connect a different institution"
msgstr "Mettre en relation un autre établissement"

#: src/views/actionableError/useActionableErrorMap.tsx
msgid "No eligible accounts"
msgstr "Aucun compte admissible"
Expand Down Expand Up @@ -2021,11 +2017,6 @@ msgstr "Succès!"
msgid "No accounts found"
msgstr "Aucun compte trouvé"

#: src/views/demoConnectGuard/DemoConnectGuard.tsx
#: src/views/actionableError/useActionableErrorMap.tsx
msgid "Return to institution selection"
msgstr "Retour à la sélection des établissements"

#: src/views/actionableError/useActionableErrorMap.tsx
msgid "Additional permissions needed"
msgstr "Autorisations supplémentaires nécessaires"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ describe('ActionableError', () => {
render(<ActionableError />, {
preloadedState: initialState,
})
const secondaryButton = screen.getByRole('button', { name: 'Connect a different institution' })
const secondaryButton = screen.getByRole('button', { name: 'Go back' })
expect(secondaryButton).toBeInTheDocument()
expect(secondaryButton).toHaveClass('MuiButton-text')
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ describe('useActionableErrorMap', () => {
})
expect(screen.getByText('No eligible accounts')).toBeInTheDocument()
expect(screen.getByText('Log in again')).toBeInTheDocument()
expect(screen.getByText('Connect a different institution')).toBeInTheDocument()
expect(screen.getByText('Go back')).toBeInTheDocument()

const primaryButton = screen.getByText('Log in again')
const secondaryButton = screen.getByText('Connect a different institution')
const secondaryButton = screen.getByText('Go back')

primaryButton.click()
expect(dispatch).toHaveBeenCalledWith({ type: ActionTypes.ACTIONABLE_ERROR_LOG_IN_AGAIN })
Expand All @@ -83,10 +83,10 @@ describe('useActionableErrorMap', () => {
preloadedState: aggregationPreloadedState,
})
expect(screen.getByText('No accounts found')).toBeInTheDocument()
expect(screen.getByText('Return to institution selection')).toBeInTheDocument()
expect(screen.getByText('Go back')).toBeInTheDocument()
expect(screen.queryByTestId('actionable-error-secondary-button')).not.toBeInTheDocument()

const primaryButton = screen.getByText('Return to institution selection')
const primaryButton = screen.getByText('Go back')

primaryButton.click()
expect(dispatch).toHaveBeenCalledWith({
Expand Down Expand Up @@ -116,10 +116,10 @@ describe('useActionableErrorMap', () => {
preloadedState: aggregationPreloadedState,
})
expect(screen.getByText('Unable to connect')).toBeInTheDocument()
expect(screen.getByText('Return to institution selection')).toBeInTheDocument()
expect(screen.getByText('Go back')).toBeInTheDocument()
expect(screen.queryByTestId('actionable-error-secondary-button')).not.toBeInTheDocument()

const primaryButton = screen.getByText('Return to institution selection')
const primaryButton = screen.getByText('Go back')

primaryButton.click()
expect(dispatch).toHaveBeenCalledWith({
Expand All @@ -133,10 +133,10 @@ describe('useActionableErrorMap', () => {
preloadedState: aggregationPreloadedState,
})
expect(screen.getByText('Maintenance in progress')).toBeInTheDocument()
expect(screen.getByText('Return to institution selection')).toBeInTheDocument()
expect(screen.getByText('Go back')).toBeInTheDocument()
expect(screen.queryByTestId('actionable-error-secondary-button')).not.toBeInTheDocument()

const primaryButton = screen.getByText('Return to institution selection')
const primaryButton = screen.getByText('Go back')

primaryButton.click()
expect(dispatch).toHaveBeenCalledWith({
Expand All @@ -150,10 +150,10 @@ describe('useActionableErrorMap', () => {
preloadedState: aggregationPreloadedState,
})
expect(screen.getByText('Unable to connect')).toBeInTheDocument()
expect(screen.getByText('Return to institution selection')).toBeInTheDocument()
expect(screen.getByText('Go back')).toBeInTheDocument()
expect(screen.queryByTestId('actionable-error-secondary-button')).not.toBeInTheDocument()

const primaryButton = screen.getByText('Return to institution selection')
const primaryButton = screen.getByText('Go back')

primaryButton.click()
expect(dispatch).toHaveBeenCalledWith({
Expand Down
10 changes: 5 additions & 5 deletions src/views/actionableError/useActionableErrorMap.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ export const useActionableErrorMap = (jobDetailCode: number) => {
"We couldn't find any accounts eligible for transfers. Please link a checking or savings account.",
),
primaryAction: { label: __('Log in again'), action: goToCredentials },
secondaryActions: { label: __('Connect a different institution'), action: goToSearch },
secondaryActions: { label: __('Go back'), action: goToSearch },
},
[ACTIONABLE_ERROR_CODES.NO_ACCOUNTS]: {
title: __('No accounts found'),
userMessage: __(
'This may be due to closed accounts, revoked access, or a connection issue. Please try again later or connect a different institution.',
),
primaryAction: { label: __('Return to institution selection'), action: goToSearch },
primaryAction: { label: __('Go back'), action: goToSearch },
},
[ACTIONABLE_ERROR_CODES.ACCESS_DENIED]: {
title: __('Additional permissions needed'),
Expand All @@ -63,19 +63,19 @@ export const useActionableErrorMap = (jobDetailCode: number) => {
userMessage: __(
"We're unable to connect to this institution right now. Please try again later.",
),
primaryAction: { label: __('Return to institution selection'), action: goToSearch },
primaryAction: { label: __('Go back'), action: goToSearch },
},
[ACTIONABLE_ERROR_CODES.INSTITUTION_MAINTENANCE]: {
title: __('Maintenance in progress'),
userMessage: __(
'The institution is temporarily unavailable due to maintenance. Please try again later.',
),
primaryAction: { label: __('Return to institution selection'), action: goToSearch },
primaryAction: { label: __('Go back'), action: goToSearch },
},
[ACTIONABLE_ERROR_CODES.INSTITUTION_UNAVAILABLE]: {
title: __('Unable to connect'),
userMessage: __("This institution isn't responding right now. Please try again later."),
primaryAction: { label: __('Return to institution selection'), action: goToSearch },
primaryAction: { label: __('Go back'), action: goToSearch },
},
}),
[dispatch],
Expand Down
Loading