CT-2495 connecting stall edits for conversation - #387
Merged
codingLogan merged 5 commits intoSep 15, 2026
Merged
Conversation
Replace the isForeignJob / nested-poll / activeJobAttempt trio in Connecting with runJobSchedule$, a pure observable that treats the backend as the source of truth: observe whatever is running, reconcile it against the schedule, start the next job, repeat. 409s and Firefly's redirect job go through the same path. The loop is capped at jobs.length + 3 iterations and errors with JobScheduleExhaustedError, which Connecting throws to the host error boundary. Previously a perpetual 409 (or an unloadable job) re-ran runJob every poll interval forever. Integration tests added for: a foreign job followed by every scheduled job, early data release still applying when nothing else is scheduled, and bounded termination under a backend that always rejects the job.
Craiting
marked this pull request as ready for review
September 15, 2026 16:38
Craiting
requested review from
Jameson13B,
ash-wright123,
mwclemy and
wesrisenmay-mx
as code owners
September 15, 2026 16:38
|
🎉 This PR is included in version 2.39.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a few rounds of AI questions for Craig's branch, combined with a few specific prompts around areas I've been involved with in the past. The result?
A few docs and plans, with a few commits to consider in a conversation