remove the plugin.install / plugin.uninstall hooks nothing dispatches - #2
Merged
Conversation
Both were registered as literal 'plugin.*' keys while this plugin declares
$module = 'licenses', and no run_event('plugin.install') exists anywhere in core
-- so neither handler has ever been reachable. The service categories and prices
getInstall() declared (CloudLinux $10, KernelCare $2.95, Imunify tiers) are long
out of date and were never applied by anything.
Owner-approved removal, per D-2 in docs/plugin-harness-findings.md.
The assertions that named the two handlers go with them -- their subject no
longer exists, so this is coverage following code rather than coverage dropped.
tests/ContractTest.php is regenerated rather than hand-edited: it pins the hook
table's shape, which is exactly what changed.
Found by the shared contract harness (B-9b, hook keys are dispatched).
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
pear/xml_rpc2 1.1.5 emits 'Using ${var} in strings is deprecated' from
Xmlrpcext/Client.php:129. This repo's phpunit config turns warnings into
failures, so the suite could not go green while that release stood -- and the
deprecation is real, not cosmetic: PHP 9 removes the syntax outright.
Upstream FIXED it in 862987e (2025-03-05) and then never released it: the last
tag is 1.1.5 from 2022, and pear/XML_RPC2 is now an ARCHIVED repository, so there
will not be a 1.1.6 from them.
Forked to myadmin-plugins/XML_RPC2 and tagged 1.1.6 at upstream trunk. The fork
carries no patch of ours -- it is upstream's own fix, released. The package name
is unchanged (pear/xml_rpc2), so this is a repositories entry rather than a
rename, and dropping that entry reverts to packagist cleanly if upstream revives.
composer.lock is gitignored in this repo, so only the manifest is committed.
Suite goes from 2 errors to green: 88 tests, 0 failures.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both hooks were registered as literal
plugin.*keys while this plugin declares$module = 'licenses', and there is norun_event('plugin.install')anywhere in core — so neither handler has ever been reachable.getInstall()declared service categories and prices (CloudLinux $10, KernelCare $2.95, Imunify tiers) that are long out of date and were never applied by anything.Owner-approved removal (D-2).
On the tests: the assertions naming the two handlers are removed with them — their subject no longer exists, so this is coverage following code, not coverage dropped.
tests/ContractTest.phpis regenerated, not hand-edited: it pins the hook table's shape, which is precisely what changed.Found by the shared contract harness (assertion B-9b, hook keys are dispatched).
Suite: 88 tests, 2 errors remaining — both pre-existing
pear/xml_rpc2PHP 8.2 deprecations, tracked as D-3 and unrelated to this change.🤖 Generated with Claude Code