Repository navigation
Reduce retained SD save latency in DeskOS 1.9.1 - #362
Merged
Merged
Conversation
n30nex
marked this pull request as ready for review
October 8, 2026 22:11
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retained stores reopened and flushed the SD card for every 192-byte chunk. Use the existing verified file stream and retain the guarded rename as the commit point. The bridge reads back the flushed temporary file before success; cancellation, card-generation checks and previous-copy recovery remain in place.
The exact 1.9.1 candidate a41f4f0 passes all five Actions jobs (2,640 host tests, 37 package tests, protocol conformance and both firmware builds) and a full Pi firmware build. Native regressions preserve the previous primary after card-byte corruption and cover retry, cancellation and failed abort cleanup.
On the physical D1L, median contact-save time fell from 8.21 to 4.27 seconds across four saves per build. Identity, 64 contacts, settings and recent DM rows survived the preserving install. Real Windows secure BLE Public transmission, two acknowledged DMs, contacts and telemetry passed on one boot, as did the actual flasher console. No SD write failures occurred during acceptance. Phone UI and signed-SD installation were not repeated; exact test limits are recorded in the release notes.