Repository navigation
Installer: join NetBird by default on new installations - #364
Merged
Merged
Conversation
A new installation joins NDP's NetBird network without --netbird, taking the management URL and the setup key from the Federation. Joining never stops it: when the Federation gives no URL or key, sudo would need a password nobody can type, or nothing can be asked, the installer says why it did not join and how to join later, and carries on; the next run tries again. --no-netbird turns it off and is remembered. --netbird keeps stopping the installation when it cannot join. An Endpoint installed before, with nothing recorded, only joins with --netbird.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #363.
Since 0.34.55 the installer only joined NDP's NetBird network with
--netbird, and the command the create-endpoint page generates does not pass it, so an Endpoint installed from the website never joined..env, no install state) joins without the flag, taking the management URL and the setup key from the Federation as--netbirddoes.sudothat would need a password nobody can type, or no terminal to ask in, the installer says why it did not join and how to join later, and carries on; the next run tries again.--no-netbirdturns it off and is remembered.--netbirdkeeps stopping the installation when it cannot join.--netbird.Version 0.34.57, CHANGELOG,
install/README.mdanddocs/configuration.mdupdated.Tests: 9 new tests in
install/tests/test_netbird_affinities.py(8 fail on main); full suite 1564 passed.Verified on a real host: an Endpoint registered from ndp-test.sdsc.edu against the test Federation and installed without
--netbirdinstalled the NetBird client, joined NDP's network (management and signal connected, NetBird address reported in its metrics), and its owner created a dataset that reached Affinities. Re-running the installer on an Endpoint installed with 0.34.56 left its.envand install state unchanged and never mentioned NetBird.