Repository navigation
Installer: record an existing NetBird connection without sudo - #368
Merged
Merged
Conversation
An unattended run on a host already connected to NDP's NetBird network reported NetBird not joined: the installer checked for passwordless sudo before looking at the connection, which needs no sudo. It now reads the connection first and only requires sudo to install the client or join. Release 0.34.58.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #367.
With 0.34.57 a new installation joins NetBird by default. Run unattended (
--yesor no terminal) on a host already connected to NDP's NetBird network, the installer said it neededsudoand wroteNETBIRD_ENABLED=False, because it checked for passwordlesssudobefore looking at the existing connection, which needs none.netbird statusas the user, throughsudoonly if that fails) and only requiressudoto install the client or join.Version 0.34.58, CHANGELOG updated.
Tests: new test in
install/tests/test_netbird_affinities.py(fails on main); full suite 1565 passed.Verified on a real host already connected to NetBird: re-running the installer unattended on a second Endpoint recorded the connection (
NETBIRD_ENABLED=True, the NetBird address, reported in its metrics), with the rest of its.envunchanged.