Repository navigation
Release: attach the installer and its SHA256SUMS to each release (#373) - #382
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #373. Checksums are done; signing is left open until an organization key is decided.
What
scripts/build_installer_asset.py <tag> <dir>writesinstall.shandSHA256SUMS, and the release workflow attaches both to every release withgh release upload --clobber.install/install.shof the tag with exactly one line set:INSTALLER_RELEASE="<tag>". So the downloaded installer installs its own release instead of the newest one.--ref, thenEP_REPO_REF, then the embedded release, then the latest release.INSTALLER_SHA256, the checksum of the installer that ran, is recorded in.env.install-state.sha256sum -c SHA256SUMS, thenbash install.sh. The docs also say what the checksum does and does not protect against.Not in this PR
Signatures (GPG, minisign or cosign) need a private key held by the organization as a repository secret. That decision is open, so this PR does not close #373.
Tests
tests/test_build_installer_asset.py.install/tests/test_default_release_ref.py(an asset installs its own release;--refstill wins), plus theINSTALLER_SHA256check.main.sha256sum -c, cloned v0.34.63 and installed an Endpoint that answered healthy.Release 0.34.64.