Skip to content

ci: run ECS deploys in the build workflow's concurrency group - #155

Closed
AdamBelfki3 wants to merge 3 commits into
mainfrom
ecs-deploy-workflow
Closed

ci: run ECS deploys in the build workflow's concurrency group#155
AdamBelfki3 wants to merge 3 commits into
mainfrom
ecs-deploy-workflow

Conversation

@AdamBelfki3

@AdamBelfki3 AdamBelfki3 commented Oct 29, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary

Follow-up to #154. Puts the Deploy to ECS workflow in the concurrency group main.yml already uses on main (build-images-refs/heads/main), so the two can't run at the same time.

Without this, a deploy started during an image build forces a new ECS deployment on the previous latest digest. It looks like a successful deploy, but the image that's still building isn't on it.

Behavior

  • A deploy started while a build on main is running waits as pending, then runs once the build finishes and ships the new image.
  • A build pushed while a deploy is running waits for the deploy to finish.
  • GitHub keeps at most one pending run per group. If a deploy is pending behind a build and another push to main queues a new build, the pending deploy is cancelled and needs re-running after that build.

Testing

  • actionlint passes on the workflow.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Deployment and image-build runs on the main branch now share scheduling, so they are coordinated rather than running concurrently. In-progress runs are not canceled when another run starts. This change affects release operations and does not alter application features or behavior.

AdamBelfki3 and others added 3 commits October 29, 2026 14:34
@AdamBelfki3 @claude
ci: add on-demand workflow to redeploy the ECS service
52b4cec 
Adds a manually triggered "Deploy to ECS" workflow that forces a new
deployment of the service running the image built by main.yml, then
tracks that deployment's rolloutState until it completes, fails, or is
rolled back. Reads the cluster and service from the ECS_CLUSTER and
ECS_SERVICE repo variables and reuses the AWS_IAM_ROLE secret.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@AdamBelfki3 @claude
ci: run ECS deploys in the build workflow's concurrency group
1fe694f 
Puts deploy-ecs.yml in the same concurrency group main.yml uses on main,
so a deploy started during an image build waits for it to finish and
ships the new image instead of the previous `latest`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@AdamBelfki3
Merge the squash-merged ecs-deploy-workflow tip so the branch fast-fo…
29a4b8d 
…rwards
@vercel

vercel Bot commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
workbench Ready Ready Preview Oct 29, 2026 7:07pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d1bf536f-88da-42ff-a558-fbde9121af3d
Commits

Reviewing files that changed from the base of the PR and between 7c98a18 and 29a4b8d.

Files selected for processing: 1
  • .github/workflows/deploy-ecs.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The ECS deployment workflow now uses the build-images-refs/heads/main concurrency group. Its cancel-in-progress setting remains false.

Changes: Deployment Concurrency

Layer / File(s) Summary
Set deployment concurrency group
.github/workflows/deploy-ecs.yml		 The workflow uses the build-images-refs/heads/main concurrency group. Deployments and image builds on main share this group. cancel-in-progress remains false.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: Minimal · up to 29a4b

No actionable merge-blocking risk was found in the supplied change.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title says ECS deploys now run in the build workflow's concurrency group, which matches the raw summary: de30 workflow switches from deploy-ecs to build-images-refs/heads/main. The objectives conf…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title says ECS deploys now run in the build workflow's concurrency group, which matches the raw summary: de30 workflow switches from deploy-ecs to build-images-refs/heads/main. The objectives confirm the purpose is to stop deploys and image builds on main from overlapping. The title uses the conventional 'ci:' prefix and stays under 70 characters. It names the primary change and does not list files.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AdamBelfki3 AdamBelfki3 mentioned this pull request Oct 29, 2026
Merged
@AdamBelfki3

AdamBelfki3 commented Oct 29, 2026

Copy link
Copy Markdown
Member Author

Superseded by #156, which carries only the concurrency commit on a fresh branch off main so it can be rebase-merged.

@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

🧹 Preview for PR #155 torn down.

@argos-ci

argos-ci Bot commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 13 removed Oct 29, 2026, 7:14 PM

This branch was successfully deployed

1 active deployment
Preview — 29a4b8dd Deployed Oct 29, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AdamBelfki3