Repository navigation
Adding versions to config - #80
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new hashing, manifest, and aggregation metadata paths are not exercised by the existing stub-based tests.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds centralized workflow version metadata and source-content hashing for provenance reporting.
Changes:
- Configures workflow versions, labels, and entry scripts.
- Generates a transitive source manifest and SHA-256 hash.
- Reports workflow metadata through aggregation and email notifications.
| File | Description |
|---|---|
nextflow.config |
Loads workflow-version configuration. |
conf/workflow_versions.config |
Defines EM-seq workflow metadata. |
main.nf |
Validates metadata and generates provenance information. |
lib/workflow_content_hash.nf |
Computes hashes and writes manifests. |
modules/aggregate_results.nf |
Forwards version and hash metadata. |
lib/notifications.nf |
Adds workflow version to emails. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| def workflow_entry_script = project_dir.resolve(params.workflows[params.workflow].entry_script) | ||
| workflow_content_hash = workflowContentHash(workflow_entry_script, project_dir) | ||
|
|
||
| if (!workflow.stubRun) { |
| --workflow "${workflow_name}" \\ | ||
| --workflow_version "${workflow_version}" \\ | ||
| ${workflow_name_modifier_arg} \\ | ||
| ${workflow_content_hash_arg} \\ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.