docs: add the release-notes improvement bullet to Store listing notes - #182
Merged
Merged
Conversation
The 1.15.0 changelog carried six user-facing items but the Microsoft Store release notes listed only five. The missing entry was the release-notes improvement itself, so Store users saw a shorter summary of the release than users on every other channel. The wording deliberately describes the notes themselves rather than the in-app update dialog. MSIX installs never see that dialog: check_for_update() short-circuits and returns None for externally-managed installs, MSIX included, which is enforced by tests/test_updater_msix.py. Describing an update dialog that Store users cannot reach would have been inaccurate for exactly the audience these notes are written for. The bullet was added to all eight languages, keeping the per-language bullet count at parity. Only the ReleaseNotes row of the generated listing CSV changes, and the longest localised value is 1030 characters, well inside the 1500-character Partner Center limit. No version strings were touched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The 1.15.0 changelog carried six user-facing items, but the Microsoft Store release notes listed only five. The missing entry was the release-notes improvement itself, so Store users saw a shorter summary of the release than users on every other channel. This adds that sixth bullet to
RELEASE_NOTESinmsix/generate_listing_csv.py, in all eight languages.Why this wording
The bullet deliberately describes the notes themselves rather than the in-app update dialog. MSIX installs never see that dialog:
check_for_update()short-circuits and returnsNonefor externally-managed installs, MSIX included, which is enforced bytests/test_updater_msix.py. Describing an update dialog that Store users cannot reach would have been inaccurate for exactly the audience these notes are written for.Verification
ReleaseNotesrow changes in the generated CSV: 1 row out of 454.de-deat 1030.APP_VERSIONremains1.15.0.The em dash (U+2014) in the notes title is this file's own existing convention and is left as-is. The bullets themselves use none.
Pre-existing debt in this file, not addressed here
Recorded so it is not lost. None of this is introduced by this PR:
SEARCH_TERMS['pt-pt']is written in English (PDF editor offline,offline PDF tools,PDF splitter software,paginate PDF documents), and slots 5 and 6 are empty strings. Every other locale is localised and fills all six. Note that only six slots are defined in total, so the "empty slot 7" is really a slot that does not exist in any language; Partner Center allows a seventh that this generator never emits.FEATURE1['zh-cn']contains the typo10 0% 离线, a stray space inside "100%". Confirmed programmatically:'10 0%' in FEATURE1['zh-cn']isTrueand'100%' in ...isFalse. This is user-visible on the Chinese Store listing.tests/forgenerate_listing_csvandlistingDatareturns nothing. The 1500-character limit and cross-language bullet parity are both validated by hand today. A test asserting those two properties would be cheap and would have caught the missing bullet automatically.🤖 Generated with Claude Code