Upgrade actions/checkout and actions/setup-java to v5 - #85
Merged
Merged
Conversation
Node.js 20 is deprecated on GitHub Actions runners, and actions/checkout@v4 and actions/setup-java@v4 were being forced onto Node.js 24 with a deprecation warning. actions/setup-java@v4 is also deprecated in favor of v5. Bump both actions to v5 across all workflows. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gj9vwiAFZwRn1N7zpzMjF3
Drop the heuristic that guessed whether KEYSTORE_FILE was a base64 string or a file path. The secret is always the base64-encoded keystore, so decode it unconditionally and update the docs example to match. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gj9vwiAFZwRn1N7zpzMjF3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-and-releasejob:actions/checkout@v4andactions/setup-java@v4run on the deprecated Node.js 20 runtime and are being force-run on Node.js 24, andactions/setup-java@v4is deprecated in favor of v5.actions/checkoutandactions/setup-javafromv4tov5in all three workflow files (pr-check.yml,release.yml,deploy-playstore.yml) so the deprecation warnings are resolved consistently across the pipeline.Test plan
PR Checkworkflow) with no Node.js 20 deprecation warnings.🤖 Generated with Claude Code
https://claude.ai/code/session_01Gj9vwiAFZwRn1N7zpzMjF3
Generated by Claude Code