Test branch: revert Bolt native deep link to bolt://ride - #91
Closed
neteinstein wants to merge 2 commits into
Closed
neteinstein wants to merge 2 commits into
neteinstein wants to merge 2 commits into
Conversation
createBoltDeepLink used the ride host (the original PR #63 hack) before PR #79/#80/#81 switched it to action based on Bolt's manifest. This test branch reverts just that host so the ride-host trick can be exercised through the real split-screen flow, not only via the Bolt Link Lab candidate list, to confirm whether it actually sets the destination on-device. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011YzvGCiBGRiG9UQnwf43yM
Lets a debug build (this test branch's bolt://ride revert included) install alongside the release app instead of overwriting it, since Android treats a different applicationId as a different app. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011YzvGCiBGRiG9UQnwf43yM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a test-only branch, not intended to be merged. It reverts
MainViewModel.createBoltDeepLinkfrom the currentbolt://action?...host back to the originalbolt://ride?...host used by the original hack in PR #63.Context: PR #63's
bolt://rideapproach was later superseded by PR #79/#80/#81, which switched tobolt://actionafter reading Bolt's own shippedAndroidManifest.xml(ee.mtakso.client) and finding that onlyactionhas a verifiedautoVerify="true"intent-filter, whilerideonly matches a generic catch-all with no host constraint. Thataction-host guess is itself still unverified against the actual query-param contract.This branch swaps just the host back to
rideso the original trick can be exercised through the real split-screen launch flow (Uber + Bolt side by side), to directly confirm on a device whether it actually sets pickup/destination in Bolt, or whether the PR #79-#81 analysis holds.createBoltDeepLinknow buildsbolt://ride?pickup_lat=...&destination_lat=...(and the plain-address fallback) instead ofbolt://action?...MainActivity, Bolt Link Lab, food delivery search, etc.) is untouchedBoltDeepLinkFormatTestto assert the reverted hostTest plan
./gradlew testin this sandbox — outbound access todl.google.com(Android Gradle Plugin) is blocked by the environment's network policy, so the build couldn't be verified locallypr-check.ymlCI (lint + unit tests) should verify compilation and the updated testbolt://ride?...🤖 Generated with Claude Code
https://claude.ai/code/session_011YzvGCiBGRiG9UQnwf43yM
Generated by Claude Code