Inject release repo slug at build time via GITHUB_REPOSITORY - #92
Merged
Merged
Conversation
Adds a GITHUB_REPO_SLUG buildConfigField sourced from the GITHUB_REPOSITORY env var GitHub Actions sets on every run, so UpdateRepositoryImpl's LATEST_RELEASE_URL always targets the repo that actually built the APK instead of a hardcoded one. Falls back to neteinstein/CompareApp for local builds outside CI. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013j66x6M3ZcMoXGZpQcLuPh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GITHUB_REPO_SLUGbuildConfigFieldinapp/build.gradle, sourced from theGITHUB_REPOSITORYenv var that GitHub Actions sets automatically on every run (owner/repo), falling back toneteinstein/CompareAppfor local builds outside CI.UpdateRepositoryImpl.LATEST_RELEASE_URLnow builds the GitHub Releases API URL fromBuildConfig.GITHUB_REPO_SLUGinstead of a hardcoded repo, so an APK always checks for updates against the repo that actually built it.Why
Follow-up to a previous request to update the hardcoded release URL. Instead of hardcoding a repo name that can drift, this makes it build-time configurable so it's automatically correct for whichever repo/fork produces the release.
Test plan
buildConfigFieldsyntax matching the existingBUILD_NUMBERpattern)dl.google.com, so a full Gradle build could not be run locally)🤖 Generated with Claude Code
https://claude.ai/code/session_013j66x6M3ZcMoXGZpQcLuPh
Generated by Claude Code