Skip to content

Format sample fixture checker warning - #306

Merged
neubig merged 1 commit into
mainfrom
fix-sample-fixture-format
Jul 5, 2026
Merged

neubig merged 1 commit into
mainfrom
fix-sample-fixture-format

Conversation

@neubig

@neubig neubig commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • apply the ruff-format rewrite for the sample fixture checker warning expression

Validation

  • python scripts/check_sample_fixtures.py --dataset openthoughts_agent_sft
  • python -m py_compile scripts/check_sample_fixtures.py
  • uv run --no-project --python /usr/bin/python3.12 --with-requirements requirements.txt pre-commit run ruff-format --files scripts/check_sample_fixtures.py

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Good taste — pure ruff-format rewrite with no logic change. Approved.

[RISK ASSESSMENT]

  • [Overall PR] ⚠️ Risk Assessment: 🟢 LOW — formatting-only change with identical runtime behaviour.

Was this automated review useful? React with 👍 or 👎 to this review to help us measure review quality.
Workflow run: https://github.com/neulab/agent-data-protocol/actions/runs/28754672805

This review was generated by an AI agent (OpenHands) on behalf of the repository maintainers.

@neubig
neubig merged commit eadc3d8 into main Jul 5, 2026
7 checks passed
@neubig
neubig deleted the fix-sample-fixture-format branch July 5, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant