Album remote operations

[surinder-tsys]

This PR contains the Remote operations for the Albums functionality.

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	35
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	162

SpotBugs increased!

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	34
Correctness	34	35
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[codecov]

Codecov Report

❌ Patch coverage is 0% with 355 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...resources/albums/CopyFileToAlbumRemoteOperation.kt	0.00%	50 Missing ⚠️
.../resources/albums/ReadAlbumItemsRemoteOperation.kt	0.00%	45 Missing ⚠️
...ud/android/lib/resources/albums/PhotoAlbumEntry.kt	0.00%	40 Missing ⚠️
...lib/resources/albums/RenameAlbumRemoteOperation.kt	0.00%	39 Missing ⚠️
...urces/albums/ToggleAlbumFavoriteRemoteOperation.kt	0.00%	39 Missing ⚠️
.../lib/resources/albums/ReadAlbumsRemoteOperation.kt	0.00%	33 Missing ⚠️
.../resources/albums/CreateNewAlbumRemoteOperation.kt	0.00%	30 Missing ⚠️
...lib/resources/albums/RemoveAlbumRemoteOperation.kt	0.00%	29 Missing ⚠️
...resources/albums/RemoveAlbumFileRemoteOperation.kt	0.00%	28 Missing ⚠️
...loud/android/lib/common/utils/WebDavFileUtils.java	0.00%	14 Missing ⚠️
... and 1 more

📢 Thoughts on this report? Let us know!

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	34
Correctness	34	35
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	9
Total	161	162

SpotBugs increased!

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	9
Total	161	161

[alperozturk96]

Thank you for the update. You can use the following command to fix spot bugs and formatting.

./gradlew detekt → it detects and gives HTML output, so that you can check it.
./gradlew :app:spotlessApply → reformats Kotlin code

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	9
Total	161	161

[alperozturk96]

The following issues were found during analysis. Please fix them where possible. Thank you.

NestedBlockDepth (You can suppress with annotation if you are not able to extract the nested blocks) → ReadAlbumItemsRemoteOperation.kt:28:18

TooGenericExceptionCaught (You can suppress with annotation since error handling in remote operation is not well-designed in the current architecture) →
→ CopyFileToAlbumRemoteOperation.kt:88:18
→ CreateNewAlbumRemoteOperation.kt:57:18
→ ReadAlbumItemsRemoteOperation.kt:68:18
→ ReadAlbumsRemoteOperation.kt:57:18
→ RemoveAlbumFileRemoteOperation.kt:45:18
→ RemoveAlbumRemoteOperation.kt:53:18
→ RenameAlbumRemoteOperation.kt:55:18

MagicNumber (You can create constants in companion object and use them):
→ CopyFileToAlbumRemoteOperation.kt:131:76
→ PhotoAlbumEntry.kt:83:61

NewLineAtEndOfFile (You can add a new line at the end of the file):
→ PhotoAlbumEntry.kt:91:2
→ ToggleAlbumFavoriteRemoteOperation.kt:73:2
→ PhotoAlbumEntryTest.kt:57:2

ReturnCount (You can try to reduce return counts. If not possible, you can use annotation to suppress it):
→ CopyFileToAlbumRemoteOperation.kt:42:18

[surinder-tsys]

The following issues were found during analysis. Please fix them where possible. Thank you.

NestedBlockDepth (You can suppress with annotation if you are not able to extract the nested blocks) → ReadAlbumItemsRemoteOperation.kt:28:18

TooGenericExceptionCaught (You can suppress with annotation since error handling in remote operation is not well-designed in the current architecture) → → CopyFileToAlbumRemoteOperation.kt:88:18 → CreateNewAlbumRemoteOperation.kt:57:18 → ReadAlbumItemsRemoteOperation.kt:68:18 → ReadAlbumsRemoteOperation.kt:57:18 → RemoveAlbumFileRemoteOperation.kt:45:18 → RemoveAlbumRemoteOperation.kt:53:18 → RenameAlbumRemoteOperation.kt:55:18

MagicNumber (You can create constants in companion object and use them): → CopyFileToAlbumRemoteOperation.kt:131:76 → PhotoAlbumEntry.kt:83:61

NewLineAtEndOfFile (You can add a new line at the end of the file): → PhotoAlbumEntry.kt:91:2 → ToggleAlbumFavoriteRemoteOperation.kt:73:2 → PhotoAlbumEntryTest.kt:57:2

ReturnCount (You can try to reduce return counts. If not possible, you can use annotation to suppress it): → CopyFileToAlbumRemoteOperation.kt:42:18

Addressed all the issues. Can you please check?

[github-actions]

SpotBugs

Category	Base	New
Bad practice	35	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	9
Total	161	161

[alperozturk96]

@tobiasKaminsky @AndyScherzinger Why REUSE Complicance Check is failing?

e.g.

/*
 * Nextcloud Android Library
 *
 * SPDX-FileCopyrightText: 2025 TSI-mc <surinder.kumar@t-systems.com>
 * SPDX-License-Identifier: AGPL-3.0-or-later
 */

It should be SPDX-License-Identifier: MIT instead of AGPL-3.0-or-later?

[AndyScherzinger]

It should be SPDX-License-Identifier: MIT instead of AGPL-3.0-or-later?

@alperozturk96 @surinder-tsys Correct, the lib is MIT hence any contribution to it has to be MIT

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[surinder-tsys]

@AndyScherzinger @alperozturk96 I have taken care of copyright and updated PR.

[github-actions]

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	9
Total	168	169

SpotBugs increased!

[alperozturk96]

@surinder-tsys Thank you for the update. There are three remaining items to address, once those are resolved, I can proceed with reviewing the client PR. If everything looks good there, we can move forward with merging this PR.

check (spotlessKotlinCheck)

src/main/java/com/owncloud/android/lib/resources/albums/CopyFileToAlbumRemoteOperation.kt:L1 ktlint(standard:max-line-length) Exceeded max line length (120)

---

[github-actions]

SpotBugs

Category	Base	New
Bad practice	31	31
Correctness	28	28
Dodgy code	14	14
Internationalization	6	6
Malicious code vulnerability	26	26
Multithreaded correctness	7	7
Performance	7	7
Security	4	4
Total	123	123

[nextcloud-android-bot]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/1736-IT-master-07-32/debug/

[nextcloud-android-bot]

stable22-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/1736-IT-stable22-07-34/debug/

[nextcloud-android-bot]

stable34-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/1736-IT-stable34-07-36/debug/

[github-actions]

SpotBugs

Category	Base	New
Bad practice	31	31
Correctness	28	28
Dodgy code	14	14
Internationalization	6	6
Malicious code vulnerability	26	26
Multithreaded correctness	7	7
Performance	7	7
Security	4	4
Total	123	123

[tobiasKaminsky]

Seems tests were only flaky ✔

[github-actions]

SpotBugs

Category	Base	New
Bad practice	31	31
Correctness	28	28
Dodgy code	14	14
Internationalization	6	6
Malicious code vulnerability	26	26
Multithreaded correctness	7	7
Performance	7	7
Security	4	4
Total	123	123