Skip to content

feat: handle post_max_size and upload_max_filesize - #1190

Draft
Ashim-Stha wants to merge 2 commits into
masterfrom
handle-max-size-error
Draft

feat: handle post_max_size and upload_max_filesize#1190
Ashim-Stha wants to merge 2 commits into
masterfrom
handle-max-size-error

Conversation

@Ashim-Stha

@Ashim-Stha Ashim-Stha commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

  • handled post_max_size error
  • handled upload_max_filesize and other related errors
  • moved the upload file functionality to the service from the controller
  • added some unit tests and updated relevant unit tests
  • updated relevant api tests

Related Issue or Workpackage

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Updated CHANGELOG.md file

@Ashim-Stha Ashim-Stha self-assigned this Oct 7, 2026
@Ashim-Stha
Ashim-Stha force-pushed the handle-max-size-error branch 29 times, most recently from af9ac32 to 60d2cb6 Compare October 13, 2026 04:19
@Ashim-Stha
Ashim-Stha force-pushed the handle-max-size-error branch from 60d2cb6 to 3257737 Compare October 16, 2026 11:15
@Ashim-Stha
feat: handle post_max_size and upload_max_filesize
c398fb0 
Signed-off-by: Ashim Shrestha <ashimshrestha2384@gmail.com>
@Ashim-Stha
refactor: move function to service
f577f58 
Signed-off-by: Ashim Shrestha <ashimshrestha2384@gmail.com>
@Ashim-Stha
Ashim-Stha force-pushed the handle-max-size-error branch 2 times, most recently from f577f58 to 2f2a252 Compare October 16, 2026 11:51
@github-actions

github-actions Bot commented Oct 16, 2026

Copy link
Copy Markdown

PHP Code Coverage

Coverage after merging handle-max-size-error into master will be
70.52%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
integration_openproject/server/apps/integration_openproject/lib
   Capabilities.php0%100%0%0%24, 31–40
   OIDCClientMapper.php0%100%0%0%29, 40–49, 52
   ServerVersion.php0%100%0%0%17, 27–29, 32, 41–42
   TokenEventFactory.php100%100%100%100%
integration_openproject/server/apps/integration_openproject/lib/AppInfo
   Application.php37.04%100%50%36%116–118, 121–135, 138, 140, 142–143, 146, 151–152, 156–159, 161–172, 174, 177, 181, 185–187, 220
integration_openproject/server/apps/integration_openproject/lib/BackgroundJob
   RemoveExpiredDirectUploadTokens.php0%100%0%0%28, 30–32, 41–42
integration_openproject/server/apps/integration_openproject/lib/Controller
   ConfigController.php77.98%100%70.59%78.32%106, 143–144, 146, 148–150, 152–155, 158–159, 161, 186, 190–192, 377–379, 381–383, 432, 512–516, 527, 541–544, 552, 556–559, 601–616, 657, 660–675, 689–695
   DirectDownloadController.php0%100%0%0%33–35, 50–52, 54–61
   DirectUploadController.php83.33%100%100%82.79%115–117, 194, 199–202, 204, 212–214, 226–228, 242–244, 264, 269, 275
   FilesController.php85.83%100%83.33%85.95%181–182, 246, 255, 272–275, 280–282, 287–289, 301, 303, 306
   OpenProjectAPIController.php81.09%100%82.35%80.98%116, 155, 202–204, 207–214, 216–220, 222, 241, 266, 331, 381, 401, 448, 473–475, 478–482, 484, 66
   OpenProjectController.php96.45%100%80%96.95%241–245
integration_openproject/server/apps/integration_openproject/lib/Dashboard
   OpenProjectWidget.php0%100%0%0%101, 108–109, 111–116, 118–122, 124–126, 129–140, 61–66, 73, 80, 87, 94
integration_openproject/server/apps/integration_openproject/lib/Exception
   OpenprojectAvatarErrorException.php100%100%100%100%
   OpenprojectErrorException.php100%100%100%100%
   OpenprojectFileNotUploadedException.php100%100%100%100%
   OpenprojectGroupfolderSetupConflictException.php100%100%100%100%
   OpenprojectResponseException.php100%100%100%100%
   OpenprojectUnauthorizedUserException.php100%100%100%100%
integration_openproject/server/apps/integration_openproject/lib/Listener
   BeforeGroupDeletedListener.php100%100%100%100%
   BeforeNodeInsideOpenProjectGroupfilderChangedListener.php0%100%0%0%46–48, 52–55, 57, 59, 62–63, 65, 67–70, 72–75, 77–79
   BeforeUserDeletedListener.php40%100%50%37.50%30, 38, 42–43, 45
   LoadAdditionalScriptsListener.php0%100%0%0%37–38, 46–47, 49, 51–52, 54
   LoadSidebarScript.php65.91%100%100%64.29%105, 77–88, 95, 98
   OpenProjectReferenceListener.php0%100%0%0%45–47, 54–55, 57, 59–60, 62–74
   TermsOfServiceEventListener.php0%100%0%0%41–42, 47–48, 50–51, 53–55, 58–62
   UserChangedListener.php0%100%0%0%34, 41–42, 45–50, 53
   UserLoggedInEventListener.php0%100%0%0%27, 35–36, 39, 42
integration_openproject/server/apps/integration_openproject/lib/Migration
   Version2001Date20221213083550.php0%100%0%0%30, 41–43, 46–54, 56–64, 66–68, 70
   Version20100Date20250820101358.php0%100%0%0%38, 47–53, 56
   Version2310Date20230116153411.php0%100%0%0%29, 32–35, 37–62, 64–65, 67
   Version2400Date20230504144300.php0%100%0%0%30, 41–44, 46
   Version2640Date20240628114301.php0%100%0%0%35, 47–49, 52–53, 56
   Version2900Date20250718065820.php0%100%0%0%22, 33–36, 38–39, 41–42, 45
integration_openproject/server/apps/integration_openproject/lib/Reference
   WorkPackageReferenceProvider.php51.67%100%25%58.33%100–101, 104, 108, 142, 150–151, 159, 37, 44, 51, 58–60, 87, 93–96, 99
integration_openproject/server/apps/integration_openproject/lib/Search
   OpenProjectSearchProvider.php0%100%0%0%100–102, 104–106, 109–110, 112–113, 116–125, 127–131, 52–55, 62, 69, 77, 79, 82, 89–90, 93–97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
integration_openproject/server/apps/integration_openproject/lib/Service
   DatabaseService.php42.31%100%60%40.43%108–112, 114, 63–76, 78–85
   DirectDownloadService.php100%100%100%100%
   DirectUploadService.php73.97%100%75%73.91%117, 133, 140, 160, 163, 84–87, 89–97
   OauthService.php96.15%100%100%95.65%124, 144
   OpenProjectAPIService.php78.41%100%80%78.29%1005–1006, 1008, 1010–1011, 1058–1060, 1062–1064, 1067–1071, 1073–1075, 1084–1087, 1090–1092, 1094,

@Ashim-Stha
Ashim-Stha force-pushed the handle-max-size-error branch from 2f2a252 to f577f58 Compare October 16, 2026 12:03
@github-actions

github-actions Bot commented Oct 22, 2026

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-nc julien-nc Awaiting requested review from julien-nc julien-nc will be requested when the pull request is marked ready for review julien-nc is a code owner
@individual-it individual-it Awaiting requested review from individual-it individual-it will be requested when the pull request is marked ready for review individual-it is a code owner
@ba1ash ba1ash Awaiting requested review from ba1ash ba1ash will be requested when the pull request is marked ready for review ba1ash is a code owner
@dominic-braeunlein dominic-braeunlein Awaiting requested review from dominic-braeunlein dominic-braeunlein will be requested when the pull request is marked ready for review dominic-braeunlein is a code owner
@Kharonus Kharonus Awaiting requested review from Kharonus Kharonus will be requested when the pull request is marked ready for review Kharonus is a code owner
@psatyal psatyal Awaiting requested review from psatyal psatyal will be requested when the pull request is marked ready for review psatyal is a code owner
@saw-jan saw-jan Awaiting requested review from saw-jan saw-jan will be requested when the pull request is marked ready for review saw-jan is a code owner
@wielinde wielinde Awaiting requested review from wielinde wielinde will be requested when the pull request is marked ready for review wielinde is a code owner
@NobodysNightmare NobodysNightmare Awaiting requested review from NobodysNightmare NobodysNightmare will be requested when the pull request is marked ready for review NobodysNightmare is a code owner
@shiroginne shiroginne Awaiting requested review from shiroginne shiroginne will be requested when the pull request is marked ready for review shiroginne is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@Ashim-Stha Ashim-Stha

Labels

feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Ashim-Stha