feat(chat): Group the files of one upload into a single message by Ivansss · Pull Request #2705 · nextcloud/talk-ios

Ivansss · 2026-09-10T14:48:09Z

Write reference ids that identify files shared together (chat and share extension)
Post the files of one upload in order
Show the files of one upload as a single message
Show images and videos as tiles and other files as cards
Open each file on its own, with download progress
Delete all files of a group at once
Collapse the deleted files of an upload into one message
Show the preview of a single file if the server has one (e.g. PDF)
Highlight the group when jumping to one of its files

Fixes #2701

🤖 AI (if applicable)

The content of this PR was partly or fully generated using AI

SystemKeeper

Just a first look at the first files.

Do we handle edit and delete of individual messages correctly?
I generally find this PR very verbose comment wise ..

SystemKeeper · 2026-09-11T06:14:24Z

+        groupedFilePreviewView.setup(with: group, account: account, availableWidth: self.availableBodyWidth)
+
+        // The caption is carried by the file shared last, which is what the group is shown as
+        let hasCaption = !group.anchor.sharesFileWithoutCaption


I wonder if we can rely on that entirely? It’s up to the uploading client, isn’t it?

What happens with old clients? What happens with reaction on individual messages or captions (which is possible on old clients and api in general).

I wonder if we can rely on that entirely? It’s up to the uploading client, isn’t it?

It is up to the client yes, but if the client is sending the group reference id (supporting grouping feature) I think we can assume the caption will be on the last message.

What happens with old clients? What happens with reaction on individual messages or captions (which is possible on old clients and api in general).

This is a current issue, at the moment only the reactions of the last message of the group will be shown.
nextcloud/spreed#19371

I think we can assume the caption will be on the last message.

But if the API/old clients can edit message in between, that's still an issue?

SystemKeeper · 2026-09-11T06:20:02Z

+
+    /// Whether the file is shown as a preview tile rather than as a row with its name.
+    ///
+    /// Only media the server can render a preview of: everything else would be a tile showing the


That is not true, but might still be intended. But the server is able to generate previews for pdfs or office documents if setup correctly

That's right, the comment needs to be updated but the functionality is intended (only images and video previews will be shown in the preview tiles)

SystemKeeper · 2026-09-11T06:23:34Z

+
+    /// The characters the agreed format allows, which is stricter than what a hash could contain:
+    /// a reference id with an uppercase letter in it is not one of ours.
+    private static let hexDigits = Set("0123456789abcdef")


The reference id format is defined as /[a-f0-9]{60}-[0-9]{3}/ in nextcloud/spreed#19040
Do you mean why implementing it like this and not with a regex?
I would update the comment since it's a bit confusing.

Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

Assisted-by: ClaudeCode:claude-opus-5.5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

Ivansss requested a review from SystemKeeper September 10, 2026 14:48

SystemKeeper force-pushed the feat/noid/group-file-messages branch from 9b66e1c to a80e001 Compare September 10, 2026 15:59

SystemKeeper reviewed Sep 11, 2026

View reviewed changes

Ivansss marked this pull request as draft September 23, 2026 14:41

Ivansss force-pushed the feat/noid/group-file-messages branch from e686c8d to 69e1540 Compare September 30, 2026 16:09

This was referenced Oct 3, 2026

fix(chat): Mark voice message as failed when its upload fails #2740

Open

Retry attachment upload automatically after a transient network error #2741

Open

Ivansss added 17 commits October 7, 2026 11:17

feat(chat): Write reference ids that identify files shared together

42e62f7

Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

fix(upload): Post messages for files shared together in order

fd330cf

Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

chore(chat): Add the grouping of files shared as one upload

26df92e

Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

feat(chat): Show the files of one upload as a single message

44dd4ef

Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

feat(chat): Make the files of a group tappable cards that show progress

e0f5d5a

Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

fix(chat): Correct the measured height of a grouped file message

eecdb06

Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

feat(chat): Draw files without a preview on a card on their own

28d12c8

Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

refactor(chat): Parse the reference id with a regular expression

1147f14

Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

refactor(chat): Give each grouped file view its own file

eae9856

Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

refactor(chat): Simplify the checks for a plain file share

dc9c7ee

Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

refactor(chat): Clarify how file messages are grouped

db1d9b9

Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

fix(chat): Measure a message body by its real insets

626da51

Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

fix(chat): Show the author of a group of files from someone else

b205db2

Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

chore(chat): Trim the comments in the file grouping code

fcd0798

Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

fix(chat): Give every tile of a group the same width

8749382

Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

fix(chat): Let a cell work out the width its previews have

55c40d8

Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

feat(chat): Delete all files of a group at once

9317a49

Assisted-by: ClaudeCode:claude-opus-5.5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

Ivansss force-pushed the feat/noid/group-file-messages branch from 69e1540 to 9317a49 Compare October 7, 2026 15:18

Ivansss added 3 commits October 8, 2026 11:41

feat(chat): Collapse the deleted files of an upload into one message

5e9864b

Assisted-by: ClaudeCode:claude-opus-5.5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

fix(chat): Only draw single files without a preview on a card

73ebd63

Assisted-by: ClaudeCode:claude-opus-5.5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

fix(chat): Highlight the group of a file when jumping to it

ea1a461

Assisted-by: ClaudeCode:claude-opus-5.5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>

Ivansss marked this pull request as ready for review October 8, 2026 11:38

Navigation Menu

Repository navigation

feat(chat): Group the files of one upload into a single message - #2705

feat(chat): Group the files of one upload into a single message#2705
Ivansss wants to merge 20 commits into
mainfrom
feat/noid/group-file-messages

Ivansss commented Sep 10, 2026 •

edited

Loading

Uh oh!

SystemKeeper left a comment

Uh oh!

SystemKeeper Sep 11, 2026

Uh oh!

Ivansss Sep 11, 2026

Uh oh!

SystemKeeper Sep 11, 2026

Uh oh!

SystemKeeper Sep 11, 2026

Uh oh!

Ivansss Sep 11, 2026

Uh oh!

SystemKeeper Sep 11, 2026

Uh oh!

Ivansss Sep 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Ivansss commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 AI (if applicable)

Uh oh!

SystemKeeper left a comment

Choose a reason for hiding this comment

Uh oh!

SystemKeeper Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

Ivansss Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

SystemKeeper Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

SystemKeeper Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

Ivansss Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

SystemKeeper Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

Ivansss Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Ivansss commented Sep 10, 2026 •

edited

Loading